Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parses the IP addr passed as CIDR from the delegated IPAM and then use the IP addr from the parsed prefix. #22918

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

vipul-21
Copy link
Contributor

@vipul-21 vipul-21 commented Jan 3, 2023

Fixes: #22917
Parses the ipaddress passed as CIDR from the delegated Ipam. And then use the ipaddress from the parsed prefix.


Fixes: #21421

@vipul-21 vipul-21 requested a review from a team as a code owner January 3, 2023 19:50
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Jan 3, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Jan 3, 2023
@christarazi
Copy link
Member

@vipul-21 Could you move the "Fixes ..." out from the commit title and into the commit msg itself? This will resolve the checkpatch failure in the CI.

@christarazi christarazi added kind/bug This is a bug in the Cilium logic. area/cni Impacts the Container Networking Interface between Cilium and the orchestrator. release-note/bug This PR fixes an issue in a previous release of Cilium. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Jan 4, 2023
@christarazi
Copy link
Member

christarazi commented Jan 4, 2023

CI is failing with

Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "fa6a4caa47ec2fddf932d3a5302381c76201298b36ca73df188a98fcd4b20ad1": unable to prepare IP addressing for ''fd00:10:244:0:1::d616'': netip.ParsePrefix("fd00:10:244:0:1::d616"): no ''/''

now

@vipul-21
Copy link
Contributor Author

vipul-21 commented Jan 4, 2023

Failed to create pod sandbox: rpc error: code = Unknown desc = failed to setup network for sandbox "fa6a4caa47ec2fddf932d3a5302381c76201298b36ca73df188a98fcd4b20ad1": unable to prepare IP addressing for ''fd00:10:244:0:1::d616'': netip.ParsePrefix("fd00:10:244:0:1::d616"): no ''/''

Is there a way I can run these test locally ?

@christarazi
Copy link
Member

I would suggest following https://docs.cilium.io/en/v1.12/gettingstarted/k8s-install-default/ as it seems like a general failure in creating any pod.

@christarazi christarazi changed the title Fixes: #22917 - Parse the Ipaddress passed as CIDR notation from dele… Parses the ipaddress passed as CIDR from the delegated Ipam. And then use the ipaddress from the parsed prefix. Jan 4, 2023
@christarazi christarazi changed the title Parses the ipaddress passed as CIDR from the delegated Ipam. And then use the ipaddress from the parsed prefix. Parses the IP addr passed as CIDR from the delegated IPAM and then use the IP addr from the parsed prefix. Jan 4, 2023
plugins/cilium-cni/main.go Show resolved Hide resolved
plugins/cilium-cni/main.go Outdated Show resolved Hide resolved
Fixes cilium#22917

Signed-off-by: vipul-21 <vipul21sept@gmail.com>
@christarazi
Copy link
Member

christarazi commented Jan 4, 2023

/test

Job 'Cilium-PR-K8s-1.16-kernel-4.9' failed:

Click to show.

Test Name

K8sDatapathConfig MonitorAggregation Checks that monitor aggregation restricts notifications

Failure Output

FAIL: Unable to retrieve all pods to restart unmanaged pods with 'kubectl -n kube-system get pods -o json': Exitcode: -1 

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.16-kernel-4.9 so I can create one.


Edit:

@vipul-21
Copy link
Contributor Author

vipul-21 commented Jan 5, 2023

K8sDatapathConfig

Seems like the issue might be a flaky one. Can we retry this ?
I'll try to replicate the issue locally.

@christarazi
Copy link
Member

@vipul-21 No need to reproduce locally. It seems that the CI failures are flakes.

@vipul-21
Copy link
Contributor Author

vipul-21 commented Jan 9, 2023

@christarazi @nathanjsweet Thanks for the review and approval. Can we merge the PR ?

@aditighag aditighag merged commit 81bd556 into cilium:master Jan 9, 2023
@joestringer joestringer added the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label Jun 13, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 13, 2023
@joestringer
Copy link
Member

I've marked this for backport since it seems to address a regression in 1.13.x in the delegated IPAM area.

@michi-covalent michi-covalent mentioned this pull request Jun 13, 2023
7 tasks
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
19 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 22, 2023
@tklauser tklauser added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cni Impacts the Container Networking Interface between Cilium and the orchestrator. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. kind/bug This is a bug in the Cilium logic. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression in latest cilium as it doesn't support IPAddress with CIDR notation from delegated ipam
7 participants