-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parses the IP addr passed as CIDR from the delegated IPAM and then use the IP addr from the parsed prefix. #22918
Conversation
@vipul-21 Could you move the "Fixes ..." out from the commit title and into the commit msg itself? This will resolve the checkpatch failure in the CI. |
ba3a9ee
to
37f9eee
Compare
37f9eee
to
5f9e9c7
Compare
CI is failing with
now |
Is there a way I can run these test locally ? |
I would suggest following https://docs.cilium.io/en/v1.12/gettingstarted/k8s-install-default/ as it seems like a general failure in creating any pod. |
5f9e9c7
to
3508636
Compare
Fixes cilium#22917 Signed-off-by: vipul-21 <vipul21sept@gmail.com>
3508636
to
5d348de
Compare
/test Job 'Cilium-PR-K8s-1.16-kernel-4.9' failed: Click to show.Test Name
Failure Output
If it is a flake and a GitHub issue doesn't already exist to track it, comment Edit:
|
Seems like the issue might be a flaky one. Can we retry this ? |
@vipul-21 No need to reproduce locally. It seems that the CI failures are flakes. |
@christarazi @nathanjsweet Thanks for the review and approval. Can we merge the PR ? |
I've marked this for backport since it seems to address a regression in 1.13.x in the delegated IPAM area. |
Fixes: #22917
Parses the ipaddress passed as CIDR from the delegated Ipam. And then use the ipaddress from the parsed prefix.
Fixes: #21421