CI: Fix Suite-runtime.RuntimeDatapathPrivilegedUnitTests #23297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandreimerink
added
area/CI
|
/test |
dylandreimerink
force-pushed
the
feature/fix-lbipam-mismatched-label-test
branch
2 times, most recently
from
794a37f
to
db4b4a7
Compare
|
/test |
nebril
approved these changes
Jan 27, 2023
|
Can't get the tests better than this. The smoke tests error on the hubble relay container: |
dylandreimerink
added
the
ready-to-merge
pchaigno
added
release-note/ci
Do we have an issue for that? I also see that the k8s-1.16-kernel-4.9 didn't run for some reason. |
We do now #23533
Oh, missed that. Perhaps we can re-trigger it, I will try |
|
/test-1.16-4.9 Job 'Cilium-PR-K8s-1.16-kernel-4.9' has 3 failures but they might be new flakes since it also hit 1 known flakes: #22056 (91.04) |
dylandreimerink
force-pushed
the
feature/fix-lbipam-mismatched-label-test
branch
from
db4b4a7
to
185d663
Compare
|
/test |
dylandreimerink
force-pushed
the
feature/fix-lbipam-mismatched-label-test
branch
from
185d663
to
8fdec44
Compare
|
/test |
dylandreimerink
force-pushed
the
feature/fix-lbipam-mismatched-label-test
branch
from
8fdec44
to
93d60b5
Compare
aspsk
approved these changes
Mar 13, 2023
|
/test |
We need to replace the t.Fatal calls with t.Error when within the await callbacks. These callbacks are called by the fake client but from the goroutine of the LBIPAM controller. This means that we panic in the controller causing us to not call `.Done` on resource events. Not calling `.Done` on resource events triggers the finalizer based checks to enforce `.Done` is always called. This masks the original error. By using t.Error we do mark the test as failed but only ever panic in the test suite itself. Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
This unit test was incorrect. It assumed that services with requested IPs whom didn't match the pool selector would be ignored. But this behavior was changed at some point during development so we instead set a status condition on the service. However the test wasn't updated. The test still returned PASS because it is time based and terminated after 100ms, but 7999/8000 times LB-IPAM takes longer than 100ms to send the update. This flake occurs only when we send the update in <100ms after start. The test has been updated to reflect the correct behavior, which surfaced a bug that was fixed as well. Fixes: cilium#23272 Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/fix-lbipam-mismatched-label-test
branch
from
93d60b5
to
d54f321
Compare
|
/test |
|
I finally got CI to agree with me on this one. We are still hitting #24217 but that is it. All reviews are in. CI green except for the flak on |
dylandreimerink
added
the
ready-to-merge
29 tasks
NikAleksandrov
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
jibi
added
backport-done/1.13
gentoo-root
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes both the masking issue and the underlying issue, please see commit descriptions for details.
Fixes: #23272