docs: Update description in egress gateway guide

[deepeshaburse]

Signed-off-by: Deepesha Burse deepesha.3007@gmail.com

Please ensure your pull request adheres to the following guidelines:

• For first time contributors, read Submitting a pull request
• All code is covered by unit and/or runtime tests where feasible.
• All commits contain a well written commit description including a title,
  description and a Fixes: #XXX line if the commit addresses a particular
  GitHub issue.
• All commits are signed off. See the section Developer’s Certificate of Origin
• Thanks for contributing!

Fixes: #23256

Document that the `install-egress-gateway-routes` flag is only for EKS's ENI mode in egress gateway guide

[jibi]

Thanks for the PR!

Could we make it a warning please? You can find an example here:

cilium/Documentation/network/egress-gateway.rst

Lines 252 to 254 in 666100d

	.. warning::
	The egress IP must be assigned to a network device on the node.

[deepeshaburse]

Thanks for the PR!

Could we make it a warning please? You can find an example here:

cilium/Documentation/network/egress-gateway.rst

Lines 252 to 254 in 666100d

	.. warning::
	The egress IP must be assigned to a network device on the node.

Sure, thanks for the review 😄

[deepeshaburse]

@jibi I have updated the file, please review it.

[qmonnet]

Looks good, thanks!

Can you please fix the formatting for the flag name and Helm value?

Can you also please squash your commits and make sure you keep only one Signed-off-by: tag in the description? Can you also extend that description by mentioning why this change is needed, please?

[deepeshaburse]

@qmonnet I'm so sorry for how messy my PR has gotten. I was able to squash the first 3 commits into one but there are a few merges before the last commit (where I remove the warning). Is there any way to squash that too?

[qmonnet]

Yes there is, probably more than one way to do it. Please have a look at my example above.
And no need to apologise! Moving around commits with Git is not exactly the most intuitive thing.

[deepeshaburse]

@qmonnet It worked! Thank you so much for walking me through every step so patiently. I really appreciate it. I finally understood the entire process. 😄

[qmonnet]

@qmonnet It worked! Thank you so much for walking me through every step so patiently. I really appreciate it. I finally understood the entire process. smile

Awesome to hear, thanks for all your efforts! Looks all good this time, and the CI test for documentation is passing.

[nbusseneau]

@deepeshaburse Thanks for your contribution!