bpf: minor CT cleanups #23718
Merged
bpf: minor CT cleanups #23718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove some dead code. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
We currently have IPv4 and IPv6 variants of several helpers that update a CT entry. These only differ in the CT tuple parameter, which then gets used as key for a map lookup. To avoid this duplication, take ct_update_nodeport() as example and turn the CT tuple into an opaque parameter. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
julianwiedmann
added
sig/datapath
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test |
dylandreimerink
approved these changes
Feb 16, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
/test-1.16-4.19 |
pchaigno
removed
the
ready-to-merge
pchaigno
approved these changes
Feb 16, 2023
| @@ -935,7 +935,7 @@ static __always_inline int lb6_local(const void *map, struct __ctx_buff *ctx, | |||
| /* See lb4_local comment */ | |||
| if (state->rev_nat_index == 0) { | |||
| state->rev_nat_index = svc->rev_nat_index; | |||
| ct_update6_rev_nat_index(map, tuple, state); | |||
There was a problem hiding this comment.
FYI: even if we don't rely on the compiler anymore to check the types, we could easily rely on Coccinelle instead to check that the second parameter is one of the two expected types.
maintainer-s-little-helper
bot
added
the
ready-to-merge
6 tasks
julianwiedmann
added
the
backport-done/1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor CT cleanups that have accumulated.