hive: Don't log interrupt signal as error #23880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
pchaigno
approved these changes
Feb 20, 2023
|
/test |
pchaigno
approved these changes
Feb 20, 2023
Hive can be stopped by sending the process a INT or TERM signal to initiate the stop of the application. Hive was logging an error "Interrupt received" when this happened and this was causing CI jobs to fail as they were checking that no errors were logged. Since stopping via SIGINT/SIGTERM is not errornous, log the event at info level instead. Fixes: cilium#23637 Fixes: b407ffc ("hive: Reimplement on top of dig") Signed-off-by: Jussi Maki <jussi@isovalent.com>
Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/fix-hive-interrupt-log
branch
from
5075383
to
ed75220
Compare
|
/test |
|
The changes are reviewed and they are trivial enough that compile test plus smoke tests should cover them. Merging. |
|
Should we backport this to v1.13? The error message seems to cause CI flakes on v1.13 (since any error is considered fatal by Jenkins CI). |
joamaki
added
the
needs-backport/1.13
15 tasks
nbusseneau
added
backport-pending/1.13
sayboras
added
backport-done/1.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hive can be stopped by sending the process a INT or TERM signal to initiate the stop of the application. Hive was logging an error "Interrupt received" when this happened and this was causing CI jobs to fail as they were checking that no errors were logged. Since stopping via SIGINT/SIGTERM is not errornous, log the event at info level instead.
Fixes: #23637
Fixes: b407ffc ("hive: Reimplement on top of dig")