Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gather cni logs in bugtool. #23937

Merged
merged 1 commit into from
Feb 24, 2023
Merged

Gather cni logs in bugtool. #23937

merged 1 commit into from
Feb 24, 2023

Conversation

marseel
Copy link
Contributor

@marseel marseel commented Feb 22, 2023 •
edited

Fixes: #23912

sysdump: Added Kubernetes CNI logs to sysdump.

@marseel marseel requested a review from a team as a code owner February 22, 2023 12:02
@maintainer-s-little-helper
Copy link

Commit 92cd947134da72cb5877634d69f079c59468b09e does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 22, 2023
@maintainer-s-little-helper
Copy link

Commit 92cd947134da72cb5877634d69f079c59468b09e does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@marseel
Gather cni logs in bugtool.
d74f571 
Fixes: cilium#23912

Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Feb 22, 2023
@nathanjsweet
Copy link
Member

nathanjsweet commented Feb 22, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.25-kernel-4.19' hit: #23944 (87.34% similarity)

@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request Feb 22, 2023
Closed
@marseel marseel added release-note/misc This PR makes changes that have no direct user impact. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. release-note/misc This PR makes changes that have no direct user impact. labels Feb 23, 2023
@nathanjsweet
Copy link
Member

There was no sysdump with the failed test.

@nathanjsweet nathanjsweet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 23, 2023
@sayboras sayboras merged commit 0c1b621 into cilium:master Feb 24, 2023
@aditighag
Copy link
Member

@marseel Can we tag this PR for backporting to 1.12 and 1.13 so that CNI logs are available as part of sysdump?

@marseel marseel added backport/1.12 This PR represents a backport for Cilium 1.12.x of a PR that was merged to main. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels May 4, 2023
@marseel
Copy link
Contributor Author

marseel commented May 4, 2023

Added labels as this is a low-risk change.

@aditighag aditighag added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch and removed backport/1.12 This PR represents a backport for Cilium 1.12.x of a PR that was merged to main. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels May 4, 2023
@aditighag
Copy link
Member

Added labels as this is a low-risk change.

@marseel FYI: I updated the correct labels.

@YutaroHayakawa YutaroHayakawa mentioned this pull request May 10, 2023
Merged
14 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 10, 2023
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 10, 2023
Merged
7 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.12 backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed needs-backport/1.12 labels May 10, 2023
This was referenced May 16, 2023
Merged
Merged
@julianwiedmann julianwiedmann added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanjsweet nathanjsweet nathanjsweet approved these changes

@squeed squeed squeed approved these changes

Assignees
No one assigned
Labels
backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bugtool: copy CNI logs as well
7 participants
@marseel @nathanjsweet @aditighag @squeed @sayboras @YutaroHayakawa @julianwiedmann