Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: Clean-up Ingress/GatewayAPI Conformance tests #24025

Merged

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Feb 25, 2023

Please refer to individual commit for more details

Fixes: #23960

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 25, 2023
@sayboras sayboras added the release-note/ci This PR makes changes to the CI. label Feb 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 25, 2023
@sayboras sayboras added area/CI Continuous Integration testing issue or flake dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. area/servicemesh GH issues or PRs regarding servicemesh labels Feb 25, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 25, 2023
@sayboras sayboras force-pushed the tam/gha-ingress-gateway-cleanup branch 5 times, most recently from c68188e to 301f882 Compare February 25, 2023 12:28
@sayboras sayboras changed the title gha: Use matrix for ConformanceIngress gha: Move to kind for Ingress/GatewayAPI Conformance tests Feb 25, 2023
@sayboras sayboras force-pushed the tam/gha-ingress-gateway-cleanup branch 13 times, most recently from 5fac91b to f29d35e Compare February 27, 2023 05:57
@sayboras sayboras changed the title gha: Move to kind for Ingress/GatewayAPI Conformance tests gha: Use cilium cli Ingress/GatewayAPI Conformance tests Feb 27, 2023
@sayboras sayboras force-pushed the tam/gha-ingress-gateway-cleanup branch 3 times, most recently from b5b61e9 to 7deaddf Compare February 27, 2023 10:27
@sayboras
Copy link
Member Author

sayboras commented Mar 6, 2023

Full CI is not required, as the changes are only related to GHA.

Marking this ready to merge.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 6, 2023
@YutaroHayakawa YutaroHayakawa merged commit c11c9f7 into cilium:master Mar 6, 2023
@sayboras sayboras deleted the tam/gha-ingress-gateway-cleanup branch March 6, 2023 11:17
@sayboras sayboras added the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label Mar 16, 2023
@sayboras
Copy link
Member Author

Nominate this PR for 1.13 backport, as this will help to improve the test stability and coverage.

@meyskens
Copy link
Member

If this PR gets backported we should also backport #24388

@sayboras sayboras mentioned this pull request Mar 18, 2023
2 tasks
@sayboras sayboras added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Mar 18, 2023
sayboras added a commit to sayboras/cilium that referenced this pull request May 3, 2023
This change was actually part of cilium#22673, but then got reverted
unintentionally due to refactor as part of cilium#24025.

Relates: cilium#24025
Relates: cilium#22673
Fixes: cilium#21993
Signed-off-by: Tam Mach <tam.mach@cilium.io>
joestringer pushed a commit that referenced this pull request May 4, 2023
This change was actually part of #22673, but then got reverted
unintentionally due to refactor as part of #24025.

Relates: #24025
Relates: #22673
Fixes: #21993
Signed-off-by: Tam Mach <tam.mach@cilium.io>
YutaroHayakawa pushed a commit to YutaroHayakawa/cilium that referenced this pull request May 15, 2023
[ upstream commit 53f26bd ]

This change was actually part of cilium#22673, but then got reverted
unintentionally due to refactor as part of cilium#24025.

Relates: cilium#24025
Relates: cilium#22673
Fixes: cilium#21993
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
aditighag pushed a commit that referenced this pull request May 15, 2023
[ upstream commit 53f26bd ]

This change was actually part of #22673, but then got reverted
unintentionally due to refactor as part of #24025.

Relates: #24025
Relates: #22673
Fixes: #21993
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
jrajahalme pushed a commit to jrajahalme/cilium that referenced this pull request May 22, 2023
[ upstream commit 53f26bd ]

This change was actually part of cilium#22673, but then got reverted
unintentionally due to refactor as part of cilium#24025.

Relates: cilium#24025
Relates: cilium#22673
Fixes: cilium#21993
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/servicemesh GH issues or PRs regarding servicemesh backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: ConformanceIngress, ConformanceGatewayAPI: error: deployment "coredns" exceeded its progress deadline
5 participants