Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

egressgw: update all internal caches once k8s state is synced #24034

Merged
merged 1 commit into from
Feb 28, 2023
Merged

egressgw: update all internal caches once k8s state is synced #24034

merged 1 commit into from
Feb 28, 2023

Conversation

jibi
Copy link
Member

@jibi jibi commented Feb 27, 2023

as we don't know which k8s events/resources were received during the initial k8s sync

@jibi jibi added release-note/bug This PR fixes an issue in a previous release of Cilium. feature/egress-gateway Impacts the egress IP gateway feature. labels Feb 27, 2023
@jibi jibi requested a review from a team as a code owner February 27, 2023 08:24
julianwiedmann
julianwiedmann approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@julianwiedmann julianwiedmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦸

@jibi
egressgw: update all internal caches once k8s state is synced
3e4cfa9 
as we don't know which k8s events/resources were received during the
initial k8s sync

Fixes: #23529
Fixes: #23967
Suggested-by: Julian Wiedmann <jwi@isovalent.com>
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi jibi force-pushed the pr/jibi/egressgw-update-caches-on-k8s-sync branch from 9d203e4 to 3e4cfa9 Compare February 27, 2023 17:36
@jibi
Copy link
Member Author

jibi commented Feb 27, 2023

/test

@jibi jibi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 28, 2023
@sayboras sayboras merged commit 2a0c158 into master Feb 28, 2023
@sayboras sayboras deleted the pr/jibi/egressgw-update-caches-on-k8s-sync branch February 28, 2023 09:17
@jibi jibi added affects/v1.12 This issue affects v1.12 branch affects/v1.13 This issue affects v1.13 branch labels Mar 24, 2023
@MrFreezeex MrFreezeex mentioned this pull request Mar 29, 2023
Closed
2 tasks
@MrFreezeex
Copy link
Member

MrFreezeex commented Mar 29, 2023 •
edited

Hi 👋, wondering is this considered for backporting (is this what the two affects tags mean 🙈)? I "recently" hit some issues were Cilium needed a restart to pick up new changes for pods matching egressgw. I couldn't reproduce on master so I suspect this PR fixes it.

@julianwiedmann
Copy link
Member

Hi wave, wondering is this considered for backporting (is that what the two affects tags mean see_no_evil)? I "recently" hit some issues were Cilium needed a restart to pick up new changes for pods matching egressgw. I couldn't reproduce on master so I suspect this PR fixes it.

Good shout - #23529 went into v1.13 stable, so we should pick this one up too.
(cc @jibi)

@julianwiedmann julianwiedmann added the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label Mar 29, 2023
@jibi jibi mentioned this pull request Apr 3, 2023
Merged
11 tasks
@jibi jibi added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 3, 2023
@jibi jibi mentioned this pull request Apr 5, 2023
Closed
2 tasks
@jibi jibi added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 7, 2023
@gentoo-root gentoo-root mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianwiedmann julianwiedmann julianwiedmann approved these changes

@dylandreimerink dylandreimerink Awaiting requested review from dylandreimerink dylandreimerink was automatically assigned from cilium/sig-datapath

Assignees
No one assigned
Labels
affects/v1.12 This issue affects v1.12 branch affects/v1.13 This issue affects v1.13 branch backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. feature/egress-gateway Impacts the egress IP gateway feature. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jibi @MrFreezeex @julianwiedmann @sayboras