Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: move poststart eni script to agent #24134

Merged
merged 1 commit into from
Mar 10, 2023
Merged

helm: move poststart eni script to agent #24134

merged 1 commit into from
Mar 10, 2023

Conversation

nebril
Copy link
Member

@nebril nebril commented Mar 2, 2023 •
edited

We rely on host having certain binaries in nodeinit scripts. They are not always available, so we are moving the eni-specific poststart hook to agent pod so that we can ensure it always runs if needed.

Related: #19256

Move poststart eni script to agent pod from nodeinit pod

@nebril nebril added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 2, 2023
@nebril nebril force-pushed the pr/nebril/move-eni-poststart-to-agent branch from ccb1649 to ee034de Compare March 2, 2023 11:47
@nebril nebril marked this pull request as ready for review March 2, 2023 11:50
@nebril nebril requested review from a team as code owners March 2, 2023 11:50
@nebril
Copy link
Member Author

nebril commented Mar 2, 2023

/test

gandro
gandro reviewed Mar 2, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for tackling this!

install/kubernetes/cilium/templates/cilium-nodeinit/daemonset.yaml Show resolved Hide resolved
install/kubernetes/cilium/templates/cilium-agent/daemonset.yaml Show resolved Hide resolved
@nebril nebril mentioned this pull request Mar 2, 2023
Merged
@nebril nebril force-pushed the pr/nebril/move-eni-poststart-to-agent branch from ee034de to 65482e3 Compare March 3, 2023 12:40
@nebril
Copy link
Member Author

nebril commented Mar 3, 2023

/test

@nebril nebril force-pushed the pr/nebril/move-eni-poststart-to-agent branch from 65482e3 to e19a243 Compare March 6, 2023 12:51
@nebril
Copy link
Member Author

nebril commented Mar 6, 2023

/test

@nebril
helm: move poststart eni script to agent
b9a4950 
We rely on host having iptables binary for nodeinit scripts. They are
not always available, so we are moving the eni-specific poststart hook
to agent pod so that we can ensure it always runs if needed.

Signed-off-by: Maciej Kwiek <maciej@isovalent.com>
@nebril nebril force-pushed the pr/nebril/move-eni-poststart-to-agent branch from e19a243 to b9a4950 Compare March 7, 2023 11:35
@nebril
Copy link
Member Author

nebril commented Mar 7, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathConfig Host firewall With VXLAN

Failure Output

FAIL: Failed to reach 192.168.56.11:80 from testserver-host-bz9kb

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

@nebril
Copy link
Member Author

nebril commented Mar 8, 2023

Hit #15455 , marking as ready to merge

@nebril nebril added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.13.1 Mar 8, 2023
@borkmann borkmann merged commit a7d3e66 into cilium:master Mar 10, 2023
@nebril nebril added this to Needs backport from master in 1.13.2 Mar 15, 2023
@nebril nebril removed this from Needs backport from master in 1.13.1 Mar 15, 2023
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 23, 2023
Merged
29 tasks
@NikAleksandrov NikAleksandrov added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 23, 2023
@nebril nebril mentioned this pull request Mar 24, 2023
Closed
@christarazi christarazi added area/helm Impacts helm charts and user deployment experience integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. labels Mar 24, 2023
@nebril nebril mentioned this pull request Apr 7, 2023
Merged
@jibi jibi added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 7, 2023
@gentoo-root gentoo-root moved this from Needs backport from master to Backport done to v1.13 in 1.13.2 Apr 14, 2023
@gentoo-root gentoo-root mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@tommyp1ckles tommyp1ckles tommyp1ckles approved these changes

Assignees
No one assigned
Labels
area/helm Impacts helm charts and user deployment experience backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. integration/cloud Related to integration with cloud environments such as AKS, EKS, GKE, etc. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.13.2
Backport done to v1.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@nebril @gandro @tommyp1ckles @jibi @borkmann @NikAleksandrov @christarazi