Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Enable conformance tests for non-SCTP traffic in conjunction with SCTP policies #24144

Merged
merged 1 commit into from
Mar 9, 2023
Merged

test: Enable conformance tests for non-SCTP traffic in conjunction with SCTP policies #24144

merged 1 commit into from
Mar 9, 2023

Conversation

joestringer
Copy link
Member

@joestringer joestringer commented Mar 2, 2023 •
edited

These tests should now be supported, so enable them.

Fixes: ae046b4 ("bpf: Add partial SCTP support.")
Related: #20033

@joestringer joestringer added release-note/ci This PR makes changes to the CI. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 2, 2023
@joestringer
Copy link
Member Author

/test-upstream-k8s

@joestringer
Copy link
Member Author

joestringer commented Mar 6, 2023 •
edited

It looks like the tests rely on Service support:

https://jenkins.cilium.io/job/Cilium-PR-K8s-Upstream/4144/execution/node/72/log/

 Summarizing 6 Failures:
   [FAIL] [sig-network] Netpol [Feature:SCTPConnectivity][LinuxOnly][Disruptive] NetworkPolicy between server and client using SCTP [It] should enforce policy to allow traffic only from a pod in a different namespace based on PodSelector and NamespaceSelector [Feature:NetworkPolicy]
   test/e2e/network/netpol/network_policy.go:1452
   [FAIL] [sig-network] Netpol [Feature:SCTPConnectivity][LinuxOnly][Disruptive] NetworkPolicy between server and client using SCTP [It] should support a 'default-deny-ingress' policy [Feature:NetworkPolicy]
   test/e2e/network/netpol/network_policy.go:1452
   [FAIL] [sig-network] NetworkPolicy [Feature:SCTPConnectivity][LinuxOnly][Disruptive] NetworkPolicy between server and client using SCTP [BeforeEach] should enforce policy to allow traffic only from a pod in a different namespace based on PodSelector and NamespaceSelector [Feature:NetworkPolicy]
   test/e2e/network/netpol/network_legacy.go:1941
   [FAIL] [sig-network] NetworkPolicy [Feature:SCTPConnectivity][LinuxOnly][Disruptive] NetworkPolicy between server and client using SCTP [BeforeEach] should enforce policy based on Ports [Feature:NetworkPolicy]
   test/e2e/network/netpol/network_legacy.go:1941
   [FAIL] [sig-network] NetworkPolicy [Feature:SCTPConnectivity][LinuxOnly][Disruptive] NetworkPolicy between server and client using SCTP [BeforeEach] should support a 'default-deny' policy [Feature:NetworkPolicy]
   test/e2e/network/netpol/network_legacy.go:1941
   [FAIL] [sig-network] Netpol [Feature:SCTPConnectivity][LinuxOnly][Disruptive] NetworkPolicy between server and client using SCTP [It] should enforce policy based on Ports [Feature:NetworkPolicy]
   test/e2e/network/netpol/network_policy.go:1452

I'll adjust the skip statement to avoid SCTP policy tests.

@joestringer
test: Enable conformance tests for SCTP
8ab74ca 
These tests should now be supported, so enable them.

Fixes: ae046b4 ("bpf: Add partial SCTP support.")
Signed-off-by: Joe Stringer <joe@cilium.io>
@joestringer
Copy link
Member Author

/test-upstream-k8s

@joestringer joestringer marked this pull request as ready for review March 7, 2023 19:37
@joestringer joestringer requested a review from a team as a code owner March 7, 2023 19:37
@joestringer joestringer changed the title test: Enable conformance tests for SCTP test: Enable conformance tests for non-SCTP traffic in conjunction with SCTP policies Mar 7, 2023
@christarazi christarazi added the area/CI Continuous Integration testing issue or flake label Mar 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.13.1 Mar 8, 2023
@joestringer joestringer merged commit 8423c45 into cilium:master Mar 9, 2023
@joestringer joestringer deleted the submit/test-sctp branch March 9, 2023 16:29
@nebril nebril added this to Needs backport from master in 1.13.2 Mar 15, 2023
@nebril nebril removed this from Needs backport from master in 1.13.1 Mar 15, 2023
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 23, 2023
Merged
29 tasks
@NikAleksandrov NikAleksandrov added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 23, 2023
@jibi jibi added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 7, 2023
@gentoo-root gentoo-root moved this from Needs backport from master to Backport done to v1.13 in 1.13.2 Apr 14, 2023
@gentoo-root gentoo-root mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christarazi christarazi christarazi approved these changes

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.13.2
Backport done to v1.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joestringer @christarazi @jibi @NikAleksandrov