Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: #24185 Cilium-operator crash on empty azure node pools #24189

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

forgems
Copy link
Contributor

@forgems forgems commented Mar 6, 2023

Empty VirtualMachineScaleSets returns 404 on ListVirtualMachineScaleSetNetworkInterfaces if there are no nodes in it. Continue with next VirtualMachineScaleSet in that case.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • [] All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Azure allows for empty user node pools. In that case ListVirtualMachineScaleSetNetworkInterfaces will return 404 when trying to get interfaces associated with given node pool. With this change it will continue with next VirtualMachineScaleSet if this is NotFound error.

Fixes: #24185

Fix Cilium Operator from crashing when encountering empty node pools on Azure

@forgems forgems requested a review from a team as a code owner March 6, 2023 11:50
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 6, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 6, 2023
@forgems
Copy link
Contributor Author

forgems commented Mar 6, 2023

I've tested it manually on azure cluster with k8s 1.24.9

@aanm aanm added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Mar 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 6, 2023
@aanm aanm added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.13.1 Mar 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.8 Mar 6, 2023
@nebril nebril added this to Needs backport from master in 1.12.9 Mar 10, 2023
@nebril nebril removed this from Needs backport from master in 1.12.8 Mar 10, 2023
@forgems
Copy link
Contributor Author

forgems commented Mar 13, 2023

@tommyp1ckles Any ETA for the review of this?

@tommyp1ckles
Copy link
Contributor

@forgems sorry for the delay - I'll take a look.

@maintainer-s-little-helper
Copy link

Commit 7819909d33dd15686a6924d496f60bdc1253feac does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Mar 14, 2023
@forgems forgems requested review from a team as code owners March 14, 2023 20:01
@christarazi christarazi added area/operator Impacts the cilium-operator component area/azure Impacts Azure based IPAM. labels Mar 14, 2023
@christarazi
Copy link
Member

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 15, 2023
@jrajahalme jrajahalme merged commit 04fe6a3 into cilium:master Mar 15, 2023
@forgems forgems deleted the azure-vmss-fix branch March 15, 2023 08:52
@nebril nebril added this to Needs backport from master in 1.13.2 Mar 15, 2023
@nebril nebril removed this from Needs backport from master in 1.13.1 Mar 15, 2023
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 20, 2023
9 tasks
@NikAleksandrov NikAleksandrov mentioned this pull request Mar 23, 2023
29 tasks
@NikAleksandrov NikAleksandrov added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 23, 2023
@youngnick youngnick added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Mar 23, 2023
@jibi jibi added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 7, 2023
@michi-covalent michi-covalent moved this from Needs backport from master to Backport done to v1.12 in 1.12.9 Apr 14, 2023
@gentoo-root gentoo-root moved this from Needs backport from master to Backport done to v1.13 in 1.13.2 Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/azure Impacts Azure based IPAM. area/operator Impacts the cilium-operator component backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.12.9
Backport done to v1.12
1.13.2
Backport done to v1.13
Development

Successfully merging this pull request may close these issues.

cilium-operator crashes when there are node pools with 0 nodes on azure
8 participants