test: Remove some {DP,Services} Ginkgo test cases #24223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer run the Ginkgo e2e tests on GKE, so remove the dead test cases. Signed-off-by: Martynas Pumputis <m@lambda.lt>
All of them are covered by ci-datapath [1]: * "Check connectivity with VXLAN encapsulation" by the "1", "4", "6" configurations. * "Check connectivity with Geneve encapsulation" by the "8" configuration. * "Check vxlan connectivity with per-endpoint routes" by the "4" configuration. [1]: https://github.com/cilium/cilium/blob/841d1f37aba6ed54b3b40853bfbed9c9bceab58b/.github/workflows/conformance-datapath.yaml#L122 Signed-off-by: Martynas Pumputis <m@lambda.lt>
All of them are covered by ci-datapath [1]: * "Check connectivity with automatic direct nodes routes" by the "2", "7" configurations. * "Check direct connectivity with per endpoint routes" by the "3", "5" configurations. [1]: https://github.com/cilium/cilium/blob/841d1f37aba6ed54b3b40853bfbed9c9bceab58b/.github/workflows/conformance-dat apath.yaml#L122 Signed-off-by: Martynas Pumputis <m@lambda.lt>
brb
added
area/CI-improvement
It is covered by [1] running on ci-datapath: "echo" pod can run on the same node as either of the "client" pods./ [1]: https://github.com/cilium/cilium-cli/blob/v0.13.1/connectivity/tests/service.go#L17 Signed-off-by: Martynas Pumputis <m@lambda.lt>
|
/test |
pchaigno
approved these changes
Mar 8, 2023
YutaroHayakawa
approved these changes
Mar 13, 2023
christarazi
approved these changes
Mar 13, 2023
pchaigno
added
the
ready-to-merge
29 tasks
NikAleksandrov
added
backport-pending/1.13
jibi
added
backport-done/1.13
gentoo-root
moved this from Needs backport from master
to Backport done to v1.13
in 1.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msgs.