pkg/k8s: set user-agent in k8s client #24275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user agent for the k8s client was never set and it was defaulting to some non-specific which would make it difficult to distinguish the Cilium requests in the kube-apiserver logs. This looks a regression introduced in fc41aeb and, similarly to the user-agent, we should make sure we are not overwriting any default QPS nor Burt values with '0'. Fixes: fc41aeb ("k8s: Add k8s-client cell") Signed-off-by: André Martins <andre@cilium.io>
aanm
added
sig/k8s
|
/test |
thorn3r
approved these changes
Mar 10, 2023
christarazi
approved these changes
Mar 10, 2023
29 tasks
NikAleksandrov
added
backport-pending/1.13
jibi
added
backport-done/1.13
gentoo-root
moved this from Needs backport from master
to Backport done to v1.13
in 1.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user agent for the k8s client was never set and it was defaulting to some non-specific which would make it difficult to distinguish the Cilium requests in the kube-apiserver logs.
This looks a regression introduced in fc41aeb and, similarly to the user-agent, we should make sure we are not overwriting any default QPS nor Burt values with '0'.
Fixes: fc41aeb ("k8s: Add k8s-client cell")