Correctly configure extra SANs for the clustermesh API server certificate when generated through certgen #24339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extends the Helm chart, to respect the extra DNS names and IP addresses specified for the clustermesh API server TLS certificate, when it is generated through the Cilium's certgen tool. The same fields are already considered when helm or cert-manager are used for generating that certificate. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
kind/bug
|
/test |
|
ConformanceGatewayAPI test hit unrelated flake #24217 |
|
The ci-datapath test failed as a consequence of #24021 |
|
/ci-datapath |
tommyp1ckles
approved these changes
Mar 22, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
added
backport-pending/1.13
gentoo-root
moved this from Needs backport from master
to Backport done to v1.13
in 1.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the Helm chart, to respect the extra DNS names and IP addresses specified for the clustermesh API server TLS certificate, when it is generated through the Cilium's certgen tool. The same fields are already considered when helm or cert-manager are used for generating that certificate.