-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Make ingress conformance ready timeout 60s #24388
Merged
aditighag
merged 1 commit into
cilium:master
from
meyskens:meyskens/up-ingress-conformance-timeout
Mar 16, 2023
Merged
[CI] Make ingress conformance ready timeout 60s #24388
aditighag
merged 1 commit into
cilium:master
from
meyskens:meyskens/up-ingress-conformance-timeout
Mar 16, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 15, 2023
meyskens
added
area/CI
Continuous Integration testing issue or flake
release-note/ci
This PR makes changes to the CI.
ci/flake
This is a known failure that occurs in the tree. Please investigate me!
labels
Mar 15, 2023
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
labels
Mar 15, 2023
meyskens
force-pushed
the
meyskens/up-ingress-conformance-timeout
branch
from
March 15, 2023 14:01
e0d62bb
to
18928ce
Compare
sayboras
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good findings 🎖️
This doubles the timeout that the ingress conformance will wait on pods becoming ready. In a kind cluster that has a lot of scheduling going on the 30s timeout caused flakes by 1 container still being created when it timed out. The default is 5 minutes in the code, this is still less to fail faster. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
meyskens
force-pushed
the
meyskens/up-ingress-conformance-timeout
branch
from
March 15, 2023 14:42
18928ce
to
03407c1
Compare
meyskens
changed the title
[WIP] Make ingress conformance ready timeout 60s
[CI Make ingress conformance ready timeout 60s
Mar 15, 2023
meyskens
changed the title
[CI Make ingress conformance ready timeout 60s
[CI] Make ingress conformance ready timeout 60s
Mar 15, 2023
The changes here are just to update the param of existing jobs, but not to update anything with GHA jobs/config/settings. So marking this ready to merge. |
sayboras
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Mar 16, 2023
sayboras
added
the
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
label
Mar 16, 2023
brlbil
approved these changes
Mar 16, 2023
8 tasks
sayboras
added
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
and removed
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
labels
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/CI
Continuous Integration testing issue or flake
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
ci/flake
This is a known failure that occurs in the tree. Please investigate me!
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/ci
This PR makes changes to the CI.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early draft PR to test multiple runs in actual CI environment
This doubles the timeout that the ingress conformance will wait on pods becoming ready.
In a kind cluster that has a lot of scheduling going on the 30s timeout caused flakes by 1 container still being created when it timed out. The default is 5 minutes in the code, this is still less to fail faster.
Fixes: #24355