Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Make ingress conformance ready timeout 60s #24388

Merged

Conversation

meyskens
Copy link
Member

@meyskens meyskens commented Mar 15, 2023

Early draft PR to test multiple runs in actual CI environment

This doubles the timeout that the ingress conformance will wait on pods becoming ready.
In a kind cluster that has a lot of scheduling going on the 30s timeout caused flakes by 1 container still being created when it timed out. The default is 5 minutes in the code, this is still less to fail faster.

Fixes: #24355

Increase timeout waiting for resources in Ingress conformance test

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 15, 2023
@meyskens meyskens added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. ci/flake This is a known failure that occurs in the tree. Please investigate me! labels Mar 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 15, 2023
@meyskens meyskens force-pushed the meyskens/up-ingress-conformance-timeout branch from e0d62bb to 18928ce Compare March 15, 2023 14:01
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good findings 🎖️

This doubles the timeout that the ingress conformance will wait on
pods becoming ready.
In a kind cluster that has a lot of scheduling going on the 30s timeout
caused flakes by 1 container still being created when it timed out.
The default is 5 minutes in the code, this is still less to fail faster.

Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
@meyskens meyskens force-pushed the meyskens/up-ingress-conformance-timeout branch from 18928ce to 03407c1 Compare March 15, 2023 14:42
@meyskens meyskens marked this pull request as ready for review March 15, 2023 14:50
@meyskens meyskens requested review from a team as code owners March 15, 2023 14:50
@meyskens meyskens changed the title [WIP] Make ingress conformance ready timeout 60s [CI Make ingress conformance ready timeout 60s Mar 15, 2023
@meyskens meyskens changed the title [CI Make ingress conformance ready timeout 60s [CI] Make ingress conformance ready timeout 60s Mar 15, 2023
@sayboras
Copy link
Member

The changes here are just to update the param of existing jobs, but not to update anything with GHA jobs/config/settings. So marking this ready to merge.

@sayboras sayboras added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 16, 2023
@sayboras sayboras added the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label Mar 16, 2023
@aditighag aditighag merged commit 166d480 into cilium:master Mar 16, 2023
@meyskens meyskens deleted the meyskens/up-ingress-conformance-timeout branch March 17, 2023 07:06
@meyskens meyskens restored the meyskens/up-ingress-conformance-timeout branch March 17, 2023 07:06
@meyskens meyskens deleted the meyskens/up-ingress-conformance-timeout branch March 17, 2023 07:06
@meyskens meyskens restored the meyskens/up-ingress-conformance-timeout branch March 17, 2023 07:06
@meyskens meyskens deleted the meyskens/up-ingress-conformance-timeout branch March 17, 2023 07:06
@brb brb mentioned this pull request Mar 17, 2023
8 tasks
@sayboras sayboras mentioned this pull request Mar 18, 2023
2 tasks
@sayboras sayboras added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ci/flake This is a known failure that occurs in the tree. Please investigate me! ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: ingress-conformance-test (With XDP, native, dedicated, false)
4 participants