v1.13 backports 2023-03-18 #24441
Merged
v1.13 backports 2023-03-18 #24441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayboras
added
kind/backports
|
Manual backport these two 2 as there are conflicts |
sayboras
force-pushed
the
pr/v1.13-backport-2023-03-18
branch
from
afd27c3
to
4521029
Compare
sayboras
force-pushed
the
pr/v1.13-backport-2023-03-18
branch
3 times, most recently
from
2df62a9
to
3d77502
Compare
[ upstream commit 4909b03 ] Use GHA matrix to avoid repetitive code Signed-off-by: Tam Mach <tam.mach@cilium.io>
[ upstream commit f028d7c ] There is issue with coredns rollout in mentioned github issue, it could be related on minikube, however, we can just switch to kind clusters for consistency and faster feedback. As the conformance test is relying on LB service, metallb installation is added. Fixes: cilium#23960 Suggested-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
[ upstream commit c11c9f7 ] There is issue with coredns rollout in mentioned github issue, it could be related on minikube, however, we can just switch to kind clusters for consistency and faster feedback. As the conformance test is relying on LB service, metallb installation is added. Fixes: cilium#23960 Suggested-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
[ upstream commit 166d480 ] This doubles the timeout that the ingress conformance will wait on pods becoming ready. In a kind cluster that has a lot of scheduling going on the 30s timeout caused flakes by 1 container still being created when it timed out. The default is 5 minutes in the code, this is still less to fail faster. Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com> Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
pr/v1.13-backport-2023-03-18
branch
2 times, most recently
from
f435f6a
to
9031b25
Compare
|
Full CI is not required as the changes are only related to GHA |
michi-covalent
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged, you can update the PR labels via: