Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf/test: Add unit test to check whether netpol drops result in metric counter increament #24469

Merged
merged 2 commits into from
Mar 22, 2023
Merged

bpf/test: Add unit test to check whether netpol drops result in metric counter increament #24469

merged 2 commits into from
Mar 22, 2023

Conversation

brb
Copy link
Member

@brb brb commented Mar 20, 2023

Also, the introduction of the BPF unit test allows us to remove the K8sDatapathCLI.

@brb brb added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/ci This PR makes changes to the CI. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 20, 2023
@brb brb force-pushed the pr/brb/ci-bpf-netpol-drop-unit-test branch 2 times, most recently from 81233af to a9c36b0 Compare March 20, 2023 14:18
@brb
Copy link
Member Author

brb commented Mar 20, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sAgentPolicyTest Multi-node policy test validates fromEntities policies Validates fromEntities all policy

Failure Output

FAIL: Timed out after 240.001s.

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

@brb brb marked this pull request as ready for review March 20, 2023 14:53
@brb brb requested review from a team as code owners March 20, 2023 14:53
@brb brb requested review from squeed, nebril and ldelossa March 20, 2023 14:53
@brb
Copy link
Member Author

brb commented Mar 20, 2023

/test-1.26-net-next

@brb brb force-pushed the pr/brb/ci-bpf-netpol-drop-unit-test branch from a9c36b0 to 000157d Compare March 21, 2023 06:07
@brb brb requested a review from julianwiedmann March 21, 2023 06:07
brb added 2 commits March 21, 2023 07:07
@brb
bpf: Add tc_lxc_policy_drop unit test
192eb60 
The unit test checks whether a policy drop increments the corresponding
BPF metrics counter.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb
test: Get rid of K8sDatapathCLI
d7d0551 
The test was replaced by the BPF unit test from the previous commit.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb force-pushed the pr/brb/ci-bpf-netpol-drop-unit-test branch from 000157d to d7d0551 Compare March 21, 2023 06:08
@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 21, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.13.2 Mar 21, 2023
@borkmann borkmann merged commit a303208 into master Mar 22, 2023
@borkmann borkmann deleted the pr/brb/ci-bpf-netpol-drop-unit-test branch March 22, 2023 15:46
@tklauser tklauser mentioned this pull request Mar 28, 2023
Merged
9 tasks
@tklauser tklauser added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.13 in 1.13.2 Mar 28, 2023
@tklauser tklauser added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Mar 31, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.2 Mar 31, 2023
@gentoo-root gentoo-root mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@nebril nebril nebril approved these changes

@aanm aanm aanm approved these changes

@julianwiedmann julianwiedmann julianwiedmann approved these changes

@ldelossa ldelossa Awaiting requested review from ldelossa ldelossa was automatically assigned from cilium/sig-datapath

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.13.2
Backport done to v1.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@brb @squeed @nebril @aanm @julianwiedmann @tklauser @borkmann