Fix race condition of deleting ccnp in e2e test #24484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
jschwinger233
force-pushed
the
gray/crd-deletion-race
branch
from
41ed28e
to
1930c8f
Compare
jschwinger233
added
kind/bug/CI
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
/test Job 'Cilium-PR-K8s-1.25-kernel-4.19' hit: #20723 (85.78% similarity) |
|
I believe the CI failure belongs to a known flake #20723, and I can't reproduce it by running locally. |
I agree. Feel free to mark ready-to-merge once it's reviewed and you have triaged CI failures with a comment. |
pchaigno
added
the
ready-to-merge
|
Let's keep 👀 on the HostFW flakes (eg. #22578) for a bit ... maybe this is all what was needed for them? @jschwinger233 we typically backport CI fixes. Could you check how far back this applies (I would assume |
There is a flake in e2e test when a test case starts to proceed before ccnp comes to take effect by cilium-agent. The correct way to delete ccnp is to run "kubectl delete" followed by "cilium policy wait", and kubectl helper already has such wrappers. Fixes: cilium#24380 Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
There is a flake in e2e test when a test case starts to proceed before cnp comes to take effect by cilium-agent. The correct way to delete cnp is to run "kubectl delete" followed by "cilium policy wait", and kubectl helper already has such wrappers. Signed-off-by: Zhichuan Liang <gray.liang@isovalent.com>
jschwinger233
force-pushed
the
gray/crd-deletion-race
branch
from
1930c8f
to
a86ef7c
Compare
ldelossa
approved these changes
Mar 30, 2023
julianwiedmann
added
needs-backport/1.11
needs-backport/1.13
|
No-change push to split the content up into two patches, and CI passed previously. |
jibi
removed
the
needs-backport/1.13
jibi
added
the
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.12
in 1.12.9
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.11
in 1.11.16
jibi
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.2
jibi
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.9
jibi
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.11
to Backport done to v1.11
in 1.11.16
This was referenced Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a flake in e2e test when a test case starts to proceed before ccnp/cnp comes to take effect by cilium-agent. The correct way to delete ccnp/cnp is to run "kubectl delete" followed by "cilium policy wait", and kubectl helper already has such wrappers.
Fixes: #24380