Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: dsr: don't track L2 addresses for DSR traffic #24524

Merged
merged 1 commit into from
Mar 27, 2023
Merged

bpf: dsr: don't track L2 addresses for DSR traffic #24524

merged 1 commit into from
Mar 27, 2023

Conversation

julianwiedmann
Copy link
Member

When DSR traffic arrives at a backend node, don't bother tracking its L2 source address. Its the LB's MAC address, but the replies need to go straight to the client.

@julianwiedmann
bpf: dsr: don't track L2 addresses for DSR traffic
5f59a61 
When DSR traffic arrives at a backend node, don't bother tracking its L2
source address. Its the LB's MAC address, but the replies need to go
straight to the client.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Mar 22, 2023
@julianwiedmann
Copy link
Member Author

Recently added these with #22978, and didn't re-consider even when challenged in #22978 (comment) 😞

@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann marked this pull request as ready for review March 22, 2023 15:41
@julianwiedmann julianwiedmann requested a review from a team as a code owner March 22, 2023 15:41
@julianwiedmann
Copy link
Member Author

runtime failed with #24342.

@julianwiedmann
Copy link
Member Author

Upgrade test in 1.26-net-next failed (#24573), and took the subsequent tests with it. Re-running.

@julianwiedmann
Copy link
Member Author

/test-1.26-net-next

@julianwiedmann julianwiedmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 27, 2023
pchaigno
pchaigno approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nice! Thanks for double checking!

@julianwiedmann julianwiedmann merged commit d8799e6 into cilium:master Mar 27, 2023
@julianwiedmann julianwiedmann deleted the 1.14-dsr-cleanups branch March 27, 2023 13:30
@julianwiedmann julianwiedmann mentioned this pull request Apr 17, 2023
Merged
6 tasks
@julianwiedmann julianwiedmann added the backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. label Apr 24, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 24, 2023
@thorn3r thorn3r mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sahid sahid sahid approved these changes

@borkmann borkmann borkmann approved these changes

@pchaigno pchaigno pchaigno approved these changes

@NikAleksandrov NikAleksandrov Awaiting requested review from NikAleksandrov NikAleksandrov was automatically assigned from cilium/sig-datapath

Assignees
No one assigned
Labels
backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@julianwiedmann @sahid @borkmann @pchaigno