bpf: port verifier test to Go #24538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
ti-mo
added
sig/loader
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
ti-mo
force-pushed
the
tb/go-verifier-test
branch
9 times, most recently
from
e4cd070
to
6decf63
Compare
ti-mo
force-pushed
the
tb/go-verifier-test
branch
from
6decf63
to
e99f7b7
Compare
Closed
ti-mo
force-pushed
the
tb/go-verifier-test
branch
3 times, most recently
from
2606a7f
to
51e8017
Compare
|
/test |
ti-mo
force-pushed
the
tb/go-verifier-test
branch
2 times, most recently
from
24dfbb0
to
f972891
Compare
ti-mo
added
the
needs-backport/1.13
ti-mo
force-pushed
the
tb/go-verifier-test
branch
from
f972891
to
30f8bab
Compare
|
@aanm Thanks! Removed the commit and the label. New workflows ran successfully: https://github.com/cilium/cilium/actions/runs/4565504149?pr=24538. |
|
/test Job 'Cilium-PR-K8s-1.16-kernel-4.19' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
As documented in the code, since we quadruple the buffer in the loop, the next step up from 4MiB is 16MiB, which would overshoot the limit of <5.2 kernels by one byte. I did not opt for doubling instead of quadrupling the buffer, since that means logs over 8MiB would also fail to load on kernels <5.2. Signed-off-by: Timo Beckers <timo@isovalent.com>
Before this patch, getCIKernelVersion would only be run if -ci-kernel-version was not specified, but on CI, it always is. This function also outputs the running kernel version to the test log. Make it so the function is always run, outputting the kernel version, and handle the flag parsing logic in the function as well. Signed-off-by: Timo Beckers <timo@isovalent.com>
This commit switches package test/verifier over from running verifier-test.sh to loading programs using Go natively. A few modifications are made to the CollectionSpec before loading: - Remove map pinning flags so each ELF gets its own copies of maps that would normally be shared across multiple ELFs by pinning them. - Run some probes over ProgramType/AttachType combinations to make sure we don't try to load cgroup programs on kernels that don't support specific attach types. verifier_test.go now tests bpf_sock as well. Also converted each line in bpf/complexity-tests/*/*.txt to run its own subtest so it's easier to spot which configuration in the list caused an error, and specific subtests can be run using go test -run=... Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
force-pushed
the
tb/go-verifier-test
branch
from
30f8bab
to
70bdb5a
Compare
|
/test |
|
I think this depends on #22754, which was not marked for backporting. Dropping the labels here until we decide what to do |
jibi
removed
the
needs-backport/1.13
jibi
added
the
needs-backport/1.13
|
Only backporting af5d551 to v1.13 |
jibi
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
jibi
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.2
tklauser
added a commit
to cilium/little-vm-helper-images
that referenced
this pull request
Jul 7, 2023
The verifier complexity test no longer uses the patched iproute2 tools since it was ported to Go, see cilium/cilium#24538 Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
to cilium/little-vm-helper-images
that referenced
this pull request
Jul 7, 2023
The verifier complexity test no longer uses the iproute2 tools since it was ported to Go, see cilium/cilium#24538 Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
to cilium/little-vm-helper-images
that referenced
this pull request
Jul 7, 2023
The verifier complexity test no longer uses the iproute2 tools since it was ported to Go, see cilium/cilium#24538 Signed-off-by: Tobias Klauser <tobias@cilium.io>
kkourt
pushed a commit
to cilium/little-vm-helper-images
that referenced
this pull request
Jul 10, 2023
The verifier complexity test no longer uses the iproute2 tools since it was ported to Go, see cilium/cilium#24538 Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #24526.
Description taken from the main commit:
Closes #24522