Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

endpoint: fix k8sNamespace log field when ep gets deleted #24575

Merged
merged 1 commit into from
Mar 29, 2023
Merged

endpoint: fix k8sNamespace log field when ep gets deleted #24575

merged 1 commit into from
Mar 29, 2023

Conversation

mhofstetter
Copy link
Member

Currently, the log field k8sNamespace contains the name of the pod instead of the actual namespace when an endpoint gets deleted. This commit fixes this and adds the k8s namespace.

@mhofstetter
endpoint: fix k8sNamespace log field when ep gets deleted
2d3aba2 
Currently, the log field k8sNamespace contains the name of the pod
instead of the actual namespace when an endpoint gets deleted. This
commit fixes this and adds the k8s namespace.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter added the release-note/misc This PR makes changes that have no direct user impact. label Mar 27, 2023
@mhofstetter mhofstetter requested a review from a team as a code owner March 27, 2023 09:13
@pchaigno
Copy link
Member

Shouldn't this be a release-note/bug and backported to v1.13? I get it's very minor but 🤷

@mhofstetter
Copy link
Member Author

Shouldn't this be a release-note/bug and backported to v1.13? I get it's very minor but shrug

sounds good to me. going to add the labels.

@mhofstetter mhofstetter added release-note/bug This PR fixes an issue in a previous release of Cilium. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch and removed release-note/misc This PR makes changes that have no direct user impact. labels Mar 27, 2023
@mhofstetter
Copy link
Member Author

mhofstetter commented Mar 27, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) Tests NodePort inside cluster (kube-proxy) with IPSec and externalTrafficPolicy=Local

Failure Output

FAIL: Request from k8s1 to service http://[fd04::11]:30178 failed

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sUpdates Tests upgrade and downgrade from a Cilium stable image to master

Failure Output

FAIL: Expected

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

@mhofstetter
Copy link
Member Author

mhofstetter commented Mar 28, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) Tests NodePort inside cluster (kube-proxy) with IPSec and externalTrafficPolicy=Local

Failure Output

FAIL: Request from k8s1 to service http://[fd04::11]:30402 failed

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

@mhofstetter
Copy link
Member Author

mhofstetter commented Mar 28, 2023 •
edited by maintainer-s-little-helper bot

/test-1.25-4.19

Job 'Cilium-PR-K8s-1.25-kernel-4.19' hit: #24602 (86.61% similarity)

@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request Mar 28, 2023
Closed
@mhofstetter
Copy link
Member Author

looks like K8sDatapathServicesTest is failing due to changes introduced with #24557 which are missing on my branch.

thanks @julianwiedmann

@mhofstetter mhofstetter added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 29, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.13.2 Mar 29, 2023
@julianwiedmann julianwiedmann merged commit 772f4a0 into cilium:master Mar 29, 2023
@mhofstetter mhofstetter deleted the pr/mhofstetter/del-ep-req-log branch March 29, 2023 11:59
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.9 Mar 30, 2023
@jibi jibi mentioned this pull request Apr 3, 2023
Merged
11 tasks
@jibi jibi added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.13 in 1.13.2 Apr 3, 2023
@jibi jibi mentioned this pull request Apr 3, 2023
Merged
3 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.12 in 1.12.9 Apr 3, 2023
@jibi jibi added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.2 Apr 7, 2023
@jibi jibi added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Apr 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.9 Apr 7, 2023
@michi-covalent michi-covalent mentioned this pull request Apr 14, 2023
Merged
@gentoo-root gentoo-root mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

Assignees
No one assigned
Labels
backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.12.9
Backport done to v1.12
1.13.2
Backport done to v1.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mhofstetter @pchaigno @jrajahalme @jibi @tklauser @julianwiedmann