Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gateway-api: Re-queue gateway for namespace change #24624

Merged
merged 1 commit into from
Apr 3, 2023
Merged

gateway-api: Re-queue gateway for namespace change #24624

merged 1 commit into from
Apr 3, 2023

Conversation

sayboras
Copy link
Member

@sayboras sayboras commented Mar 29, 2023 •
edited

Description

This commit is to make sure that if there is any changes in namespace mentioned in gateway.spec.listener[].allowRoutes, the reconciliation loop should kick off for Gateway resource. For example, the namespace label can be added to be included or excluded from what mentioned in gateway.spec.listener[*].allowRoutes.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 29, 2023
@sayboras sayboras changed the title gateway-api: Re-queue gateway for namespace change in allowRoutes gateway-api: Re-queue gateway for namespace change Mar 29, 2023
@sayboras sayboras added the release-note/bug This PR fixes an issue in a previous release of Cilium. label Mar 29, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 29, 2023
@sayboras sayboras added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Mar 29, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 29, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.13.2 Mar 29, 2023
@sayboras sayboras force-pushed the tam/httproute-cross-ns branch 2 times, most recently from ba2b2e6 to 984f3aa Compare March 29, 2023 11:26
@sayboras sayboras marked this pull request as ready for review March 29, 2023 11:54
@sayboras sayboras requested a review from a team as a code owner March 29, 2023 11:54
@sayboras sayboras requested a review from youngnick March 29, 2023 11:54
@sayboras sayboras marked this pull request as draft March 29, 2023 13:30
@sayboras
gateway-api: Re-queue gateway for namespace change in allowRoutes
4e83f5a 
This commit is to make sure that if there is any changes in namespace
mentioned in gateway.spec.listener[*].allowRoutes, the reconciliation
loop should kick off for Gateway resource. For example, the namespace
label can be added to be included or excluded from what mentioned in
gateway.spec.listener[*].allowRoutes.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras marked this pull request as ready for review April 1, 2023 12:11
@sayboras
Copy link
Member Author

sayboras commented Apr 3, 2023 •
edited by maintainer-s-little-helper bot

/test

Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed:

Click to show.

Test Name

K8sDatapathConfig Host firewall With VXLAN

Failure Output

FAIL: Error deleting resource /home/jenkins/workspace/Cilium-PR-K8s-1.24-kernel-5.4/src/github.com/cilium/cilium/test/k8s/manifests/host-policies.yaml: Cannot retrieve "cilium-7vmmc"'s policy revision: cannot get policy revision: ""

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.24-kernel-5.4 so I can create one.

@sayboras
Copy link
Member Author

sayboras commented Apr 3, 2023 •
edited by maintainer-s-little-helper bot

/mlh new-flake Cilium-PR-K8s-1.24-kernel-5.4

👍 created #24697 #24698 #24699 #24700

@sayboras
Copy link
Member Author

sayboras commented Apr 3, 2023

/test-1.24-5.4

1 similar comment
@sayboras
Copy link
Member Author

sayboras commented Apr 3, 2023

/test-1.24-5.4

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 3, 2023
@sayboras sayboras merged commit 9629343 into cilium:master Apr 3, 2023
42 checks passed
@sayboras sayboras deleted the tam/httproute-cross-ns branch April 3, 2023 15:06
@jibi jibi mentioned this pull request Apr 5, 2023
Merged
6 tasks
@jibi jibi added the backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. label Apr 5, 2023
@jibi jibi added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 5, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.13 in 1.13.2 Apr 7, 2023
@gentoo-root gentoo-root mentioned this pull request Apr 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhofstetter mhofstetter mhofstetter approved these changes

@youngnick youngnick youngnick approved these changes

Assignees
No one assigned
Labels
backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
No open projects
1.13.2
Backport done to v1.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sayboras @mhofstetter @youngnick @jibi