egressgw: init gatewayIP to 0.0.0.0 #24646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
8 tasks
MrFreezeex
force-pushed
the
egressgw-default-value
branch
from
cd1fc2a
to
73bf8f9
Compare
jibi
added
kind/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
jibi
reviewed
Mar 30, 2023
jibi
added
the
needs-backport/1.13
Always init gatewayIP to 0.0.0.0 by default instead of the previous nil value. Before this commit the rules that didn't match any node where added in addMissingEgressRules and removed right after in removeUnusedEgressRules. The egressmap auto convert nil to 0.0.0.0 and removeUnusedEgressRules doesn't do anything to match nil and 0.0.0.0. Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
MrFreezeex
force-pushed
the
egressgw-default-value
branch
from
73bf8f9
to
0196205
Compare
|
/test |
|
/test-1.26-net-next Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
(looks like net-next is hitting #24667) |
|
/mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next |
|
|
jibi
added
the
ready-to-merge
|
@jibi Note I don't think MLH managed to create the flake issue. |
pchaigno
removed
the
ready-to-merge
|
We're also missing an approving review. |
jibi
approved these changes
Apr 3, 2023
I thought I had already approved it |
jibi
added
the
ready-to-merge
jibi
removed
the
needs-backport/1.13
jibi
added
the
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
jibi
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Always init gatewayIP to 0.0.0.0 by default instead of the previous nil value. Before this commit the rules that didn't match any node where added in addMissingEgressRules and removed right after in removeUnusedEgressRules. The egressmap auto convert nil to 0.0.0.0 and removeUnusedEgressRules doesn't do anything to match nil and 0.0.0.0.