helm: mandate issuer configuration when using cert-manager to generate certificates #24666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit bc2ed14. Currently, in the helm chart, if the cert-manager approach is selected to generate the hubble and clustermesh certificates but no issuer is specified, a new issuer is created for each of them, along with a secret containing the CA information. Still, this approach is currently broken, since the CA secret which is created does not match the format expected by cert-manager. At the same time, this might also hide misconfigurations (e.g., if there is a typo in the issuer configuration) and possibly lead to different CAs for different components. Hence, let's just stick to the approach documented in the user guide and make it mandatory to specify the issuer when cert-manager is used. It is a task of the users (as unrelated from cilium) to create the appropriate issuer in advance, according to their own preference. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
kind/bug
This reverts commit 082fa15. Currently, in the helm chart, if the cert-manager approach is selected to generate the hubble and clustermesh certificates but no issuer is specified, a new issuer is created for each of them, along with a secret containing the CA information. Still, this approach is currently broken, since the CA secret which is created does not match the format expected by cert-manager. At the same time, this might also hide misconfigurations (e.g., if there is a typo in the issuer configuration) and possibly lead to different CAs for different components. Hence, let's just stick to the approach documented in the user guide and make it mandatory to specify the issuer when cert-manager is used. It is a task of the users (as unrelated from cilium) to create the appropriate issuer in advance, according to their own preference. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
force-pushed
the
mio/helm-cert-manager
branch
from
35dac97
to
d84bc71
Compare
|
I'm not running the additional tests, since they would provide no additional coverage for this helm-related change. |
sayboras
approved these changes
Apr 2, 2023
install/kubernetes/cilium/templates/hubble/tls-certmanager/server-secret.yaml
Show resolved
Hide resolved
install/kubernetes/cilium/templates/clustermesh-apiserver/tls-certmanager/server-secret.yaml
Show resolved
Hide resolved
kaworu
approved these changes
Apr 3, 2023
rolinh
approved these changes
Apr 3, 2023
tommyp1ckles
approved these changes
Apr 5, 2023
|
Marking as ready to merge without running the additional tests, as this includes helm related changes and they would provide no additional coverage. |
giorio94
added
the
ready-to-merge
8 tasks
pchaigno
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.12
in 1.12.9
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.12
in 1.12.9
gandro
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.2
gandro
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in the helm chart, if the cert-manager approach is selected to generate the hubble and clustermesh certificates but no issuer is specified, a new issuer is created for each of them, along with a secret containing the CA information. Still, this approach is currently broken, since the CA secret which is created does not match the format expected by cert-manager. At the same time, this might also hide misconfigurations (e.g., if there is a typo in the issuer configuration) and possibly lead to different CAs for different components. Hence, let's just stick to the approach documented in the user guide and make it mandatory to specify the issuer when cert-manager is used. It is a task of the users (as unrelated from cilium) to create the appropriate issuer in advance, according to their own preference.
This PR supersedes #24505, since the automatic creation of a per-component self-signed issuer would lead to certificates signed by different authorities, which is something we are trying to move away (https://github.com/cilium/cilium/blob/master/install/kubernetes/cilium/values.yaml#L1000-L1002). Using a well-defined CA, shared among all clusters to be joined with clustermesh is also the best practice for a smooth setup, and we should encourage it (https://docs.cilium.io/en/v1.13/network/clustermesh/clustermesh/#shared-certificate-authority).
I'm marking this as a bug fix, since selecting cert-manager and leaving the issuer unset currently leads to a broken setup (since the certificates are never generated due to the incorrect secret content).
I'm marking this for backport to v1.12 and v1.13 since the reverted PR (#22921) which removed the validation has been backported to those versions.
Fixes: #24500