-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/service: Backends leak follow ups with revised fixes, debugging improvements and unit tests #24770
pkg/service: Backends leak follow ups with revised fixes, debugging improvements and unit tests #24770
Conversation
ConformanceKind hit - #22217. |
I'll piggyback on the PR to add documentation changes. |
430fd35
to
b49fa61
Compare
b49fa61
to
7db1f0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aditighag 👋🏻 Thanks for this update. I left some edits for clarity, otherwise LGTM from a docs perspective.
Thanks for the docs review @zacharysarah. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are the original author for most of the code, so you have the most context.
It's no longer the case, as I stopped tracking changes the package long time ago.
This is a follow-up PR with revised fixes along with debugging improvements, and test coverage for fixes merged in - #24681.
pkg/service: Extend logic to handle leaked backends
pkg/service: Fix premature release of backend ID
pkg/service: Log skipped backends count during restore
pkg/service: Log orphan backends count
Debugging improvements
pkg/service: Unit test for handling of leaked backends in various scenarios described above
docs: Document backends leak issue
Document the issue along with affected Cilium versions.
Relates: #23551
Signed-off-by: Aditi Ghag aditi@cilium.io