Fix connectivity issue if nodes share the same name across the clustermesh and wireguard is enabled #24785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giorio94
added
kind/bug
giorio94
force-pushed
the
mio/clustermesh-wireguard-same-node-name
branch
2 times, most recently
from
3fea3e9
to
e03cff2
Compare
|
/test |
giorio94
requested review from
NikAleksandrov,
a team and
brb
and removed request for
a team
|
/ci-eks Hit unrelated flake #24774 |
|
The ConformanceEKS test hit again the same unrelated flake. I'm not rerunning it, since it wouldn't test anything wireguard-related in any case. |
pchaigno
requested review from
YutaroHayakawa
and removed request for
NikAleksandrov
|
test-1.27-net-next failures:
|
|
Marking as ready to merge, since reviews are in, and test failures are due to known flakes (and unrelated, as wireguard is not enabled). |
giorio94
added
the
ready-to-merge
4 tasks
7 tasks
15 tasks
nbusseneau
added
backport-pending/1.13
8 tasks
sayboras
added
backport-done/1.13
jrajahalme
moved this from Needs backport from main
to Backport done to v1.11
in 1.11.17
This was referenced May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the wireguard subsystem in the cilium agent caches information about the known peers by node name only. This can lead to conflicts in case of clustermesh, if nodes in different clusters have the same name, causing in turn connectivity issues. Hence, let's switch to identify peers by full name (i.e., cluster-name/node-name) to ensure uniqueness.
Fixes: #24227
Reported-by: @oulinbao