bpf: dsr: fix parsing of IPv6 AUTH extension header #24792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When walking an IPv6 packet's extension headers to find a DSR extension, only advance the `nh` variable _after_ calculating the current extension header's length. For AUTH headers we otherwise fail to determine the correct header length. We recently fixed the same issue in the generic IPv6 code with commit e76d074 ("bpf: fix ipv6 extension header parsing error"), but missed that the nodeport code has its own IPv6 extension header parsing logic. Fixes: 5fbf127 ("datapath: Support multiple IPv6 extensions with DSR") Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
sig/datapath
|
/test |
pchaigno
approved these changes
Apr 9, 2023
|
|
julianwiedmann
added
kind/bug
pchaigno
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.13
in 1.13.2
gandro
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.2
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When walking an IPv6 packet's extension headers to find a DSR extension, only advance the
nhvariable after calculating the current extension header's length. For AUTH headers we otherwise fail to determine the correct header length.We recently fixed the same issue in the generic IPv6 code with commit e76d074 ("bpf: fix ipv6 extension header parsing error"), but missed that the nodeport code has its own IPv6 extension header parsing logic.
Fixes: 5fbf127 ("datapath: Support multiple IPv6 extensions with DSR")