Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: Mark CES feature as beta in agent flag #24850

Merged
merged 1 commit into from
Apr 19, 2023
Merged

daemon: Mark CES feature as beta in agent flag #24850

merged 1 commit into from
Apr 19, 2023

Conversation

pchaigno
Copy link
Member

This commit marks the CiliumEndpointSlice feature as beta (as per the documentation) in the agent flag description. This is necessary because users don't always read the full documentation before turning agent flags on.

While at it, change the flag description to match the wording of other flags.

@pchaigno pchaigno added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.11 sig/agent Cilium agent related. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 12, 2023
@pchaigno pchaigno requested a review from qmonnet April 12, 2023 20:48
@pchaigno pchaigno requested a review from a team as a code owner April 12, 2023 20:48
@pchaigno pchaigno requested a review from thorn3r April 12, 2023 20:48
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.12.9 Apr 12, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.13.2 Apr 12, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.16 Apr 12, 2023
@pchaigno
daemon: Mark CES feature as beta in agent flag
fec2980 
This commit marks the CiliumEndpointSlice feature as beta (as per the
documentation) in the agent flag description. This is necessary because
users don't always read the full documentation before turning agent
flags on.

While at it, change the flag description to match the wording of other
flags.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@michi-covalent michi-covalent added this to Needs backport from master in 1.12.10 Apr 14, 2023
@michi-covalent michi-covalent removed this from Needs backport from master in 1.12.9 Apr 14, 2023
@michi-covalent michi-covalent added this to Needs backport from master in 1.11.17 Apr 14, 2023
@michi-covalent michi-covalent removed this from Needs backport from master in 1.11.16 Apr 14, 2023
qmonnet
qmonnet approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@gentoo-root gentoo-root added this to Needs backport from master in 1.13.3 Apr 14, 2023
@gentoo-root gentoo-root removed this from Needs backport from master in 1.13.2 Apr 14, 2023
thorn3r
thorn3r approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@thorn3r thorn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@pchaigno
Copy link
Member Author

Changes are trivial, compile, and are reviewed. Marking ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 19, 2023
@ldelossa ldelossa merged commit a6d0142 into cilium:main Apr 19, 2023
42 checks passed
@pchaigno pchaigno deleted the mark-ces-feature-beta branch April 19, 2023 14:46
@nbusseneau nbusseneau mentioned this pull request Apr 20, 2023
Merged
4 tasks
@nbusseneau nbusseneau mentioned this pull request Apr 20, 2023
Merged
7 tasks
@nbusseneau nbusseneau mentioned this pull request Apr 20, 2023
Merged
15 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 20, 2023
@sayboras sayboras added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-pending/1.12 labels Apr 26, 2023
@jrajahalme jrajahalme moved this from Needs backport from main to Backport done to v1.11 in 1.11.17 May 12, 2023
This was referenced May 12, 2023
Closed
Closed
Closed
Merged
@thorn3r thorn3r moved this from Needs backport from main to Backport done to v1.12 in 1.12.10 May 16, 2023
@thorn3r thorn3r mentioned this pull request May 16, 2023
Merged
@thorn3r thorn3r moved this from Needs backport from main to Backport done to v1.13 in 1.13.3 May 17, 2023
@thorn3r thorn3r mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@thorn3r thorn3r thorn3r approved these changes

Assignees
No one assigned
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/agent Cilium agent related.
Projects
No open projects
1.11.17
Backport done to v1.11
1.12.10
Backport done to v1.12
1.13.3
Backport done to v1.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pchaigno @qmonnet @thorn3r @nbusseneau @ldelossa @sayboras