Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: small fixes for k8s upgrade guide #24869

Merged
merged 2 commits into from
Apr 17, 2023
Merged

docs: small fixes for k8s upgrade guide #24869

merged 2 commits into from
Apr 17, 2023

Conversation

tklauser
Copy link
Member

Noticed while working on #24837, see commit messages for details.

@tklauser
docs: adjust trigger phrases in k8s update instructions
e21b2b6 
The 4.9 pipeline got removed in commit bbda112 ("test: Get rid of
4.9 pipeline"). We now run the latest k8s version on 4.19. Adjust the
example trigger phrases accordingly.

Also correct the trigger phrase for running the k8s upstream tests.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser
docs: fix formatting of numbered list in k8s update instructions
161eb8a 
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. release-note/misc This PR makes changes that have no direct user impact. labels Apr 13, 2023
@tklauser tklauser requested review from a team as code owners April 13, 2023 13:30
bimmlerd
bimmlerd approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good 👀 :)

@qmonnet qmonnet added needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 17, 2023
@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 17, 2023
@ldelossa
Copy link
Contributor

docs pr, merging without tests.

@ldelossa ldelossa merged commit 3bb8602 into master Apr 17, 2023
35 checks passed
@ldelossa ldelossa deleted the pr/tklauser/docs-k8s-update-fixes branch April 17, 2023 18:10
@nbusseneau nbusseneau mentioned this pull request Apr 20, 2023
Merged
7 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot removed the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 20, 2023
@nbusseneau nbusseneau mentioned this pull request Apr 20, 2023
Merged
15 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 20, 2023
@sayboras sayboras added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-pending/1.12 labels Apr 26, 2023
This was referenced May 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bimmlerd bimmlerd bimmlerd approved these changes

@qmonnet qmonnet qmonnet approved these changes

@zacharysarah zacharysarah Awaiting requested review from zacharysarah zacharysarah was automatically assigned from cilium/docs-structure

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tklauser @ldelossa @bimmlerd @qmonnet @nbusseneau @sayboras