Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

envoy: Debug log remote IDs for Envoy policies #24939

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

jrajahalme
Copy link
Member

Try get more information on an apparent race with Envoy policy updates and selector cache (FQDN) ID updates by logging the matching remote IDs when updating network policy for Envoy.

Try get more information on an apparent race with Envoy policy updates
and selector cache (FQDN) ID updates by logging the matching remote IDs
when updating network policy for Envoy.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme added area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. needs-backport/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 17, 2023
@jrajahalme jrajahalme requested review from a team as code owners April 17, 2023 23:47
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 17, 2023
@jrajahalme jrajahalme added the release-note/misc This PR makes changes that have no direct user impact. label Apr 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 17, 2023
Copy link
Member

@asauber asauber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrajahalme
Copy link
Member Author

Adding debug logs does not require running Ginkgo tests, labeling as ready-to-merge.

@jrajahalme jrajahalme added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 19, 2023
@ldelossa ldelossa merged commit b6f67c8 into cilium:main Apr 19, 2023
44 checks passed
@nbusseneau nbusseneau mentioned this pull request Apr 20, 2023
7 tasks
@nbusseneau nbusseneau mentioned this pull request Apr 20, 2023
15 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 20, 2023
@sayboras sayboras added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-pending/1.12 labels Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/proxy Impacts proxy components, including DNS, Kafka, Envoy and/or XDS servers. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants