Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/nodediscovery: add security tags as part of CiliumNode #24951

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

aanm
Copy link
Member

@aanm aanm commented Apr 18, 2023

The security tags were missing in the CiliumNode because they were never copied from the CiliumCNI configuration. This commit adds that missing functionality.

Fix security-group-tags not working in ENI

Fixes #23678

The security tags were missing in the CiliumNode because they were never
copied from the CiliumCNI configuration. This commit adds that
missing functionality.

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. area/eni Impacts ENI based IPAM. labels Apr 18, 2023
@aanm aanm requested a review from christarazi April 18, 2023 12:48
@aanm aanm requested a review from a team as a code owner April 18, 2023 12:48
@aanm
Copy link
Member Author

aanm commented Apr 18, 2023

/test

@aanm
Copy link
Member Author

aanm commented Apr 18, 2023

/test-1.26-net-next

@aanm
Copy link
Member Author

aanm commented Apr 18, 2023

/ci-datapath

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 18, 2023
@christarazi christarazi merged commit 290a764 into cilium:main Apr 19, 2023
58 checks passed
@aanm aanm deleted the pr/fix-security-tags branch April 19, 2023 23:26
@aanm aanm added affects/v1.11 This issue affects v1.11 branch affects/v1.12 This issue affects v1.12 branch needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch affects/v1.13 This issue affects v1.13 branch labels Apr 19, 2023
@nbusseneau nbusseneau mentioned this pull request Apr 20, 2023
15 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 20, 2023
@sayboras sayboras added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects/v1.11 This issue affects v1.11 branch affects/v1.12 This issue affects v1.12 branch affects/v1.13 This issue affects v1.13 branch area/eni Impacts ENI based IPAM. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENI: security-group-tags not working
4 participants