Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mlh: update Jenkins jobs following removal of kernel 4.9 support #24955

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

nbusseneau
Copy link
Member

We removed support for kernel 4.9 in the CI via 6930e42, as part of ongoing work to bump the minimal supported kernel version (see 1), but we forgot to rotate the CI jobs as we had previously done on master via 7d108b9.

This commit fixes this by making similar changes on v1.13.

We have rotated / expanded the Jenkins test jobs as follow:

  • Changed: K8s 1.16 on Kernel 4.19 (instead of 4.9, triggered on /test).
  • Changed: K8s 1.17-1.24 on Kernel 4.19 (instead of 4.9, triggered on /test-missed-k8s).

See the Table of Truth™️ for up to date status on all trigger phrases: https://docs.google.com/spreadsheets/d/1TThkqvVZxaqLR-Ela4ZrcJ0lrTJByCqrbdCjnI32_X0/edit#gid=0

We removed support for kernel 4.9 in the CI via
6930e42, as part of ongoing work to
bump the minimal supported kernel version (see [1]), but we forgot to
rotate the CI jobs as we had previously done on `master` via
7d108b9.

This commit fixes this by making similar changes on `v1.13`.

We have rotated / expanded the Jenkins test jobs as follow:

- Changed: K8s 1.16 on Kernel 4.19 (instead of 4.9, triggered on `/test`).
- Changed: K8s 1.17-1.24 on Kernel 4.19 (instead of 4.9, triggered on `/test-missed-k8s`).

See the Table of Truth™️ for up to date status on all trigger phrases:
https://docs.google.com/spreadsheets/d/1TThkqvVZxaqLR-Ela4ZrcJ0lrTJByCqrbdCjnI32_X0/edit#gid=0

[1]: cilium#22116

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Apr 18, 2023
@nbusseneau nbusseneau requested a review from a team as a code owner April 18, 2023 16:05
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Apr 18, 2023
@nbusseneau
Copy link
Member Author

nbusseneau commented Apr 18, 2023

/test-backport-1.13

EDIT: all expected jobs have been triggered.

Job 'Cilium-PR-K8s-1.24-kernel-5.4' hit: #24697 (88.83% similarity)

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathVerifier Runs the kernel verifier against Cilium's BPF datapath

Failure Output

FAIL: terminating containers are not deleted after timeout

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.25-kernel-4.19/1822/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

@nbusseneau
Copy link
Member Author

nbusseneau commented Apr 18, 2023

EDIT: it is done.

@aanm @joestringer The following PR checks need to be marked as required in GH settings for the v1.13 branch:

  • k8s-1.16-kernel-4.19 (test-1.16-4.19)
  • k8s-1.17-kernel-4.19 (test-1.17-4.19)
  • k8s-1.18-kernel-4.19 (test-1.18-4.19)
  • k8s-1.19-kernel-4.19 (test-1.19-4.19)
  • k8s-1.20-kernel-4.19 (test-1.20-4.19)
  • k8s-1.21-kernel-4.19 (test-1.21-4.19)
  • k8s-1.22-kernel-4.19 (test-1.22-4.19)
  • k8s-1.23-kernel-4.19 (test-1.23-4.19)
  • k8s-1.24-kernel-4.19 (test-1.24-4.19)

The following need to be unmarked:

  • k8s-1.16-kernel-4.9 (test-1.16-4.9)
  • k8s-1.17-kernel-4.9 (test-1.17-4.9)
  • k8s-1.18-kernel-4.9 (test-1.18-4.9)
  • k8s-1.19-kernel-4.9 (test-1.19-4.9)
  • k8s-1.20-kernel-4.9 (test-1.20-4.9)
  • k8s-1.21-kernel-4.9 (test-1.21-4.9)
  • k8s-1.22-kernel-4.9 (test-1.22-4.9)
  • k8s-1.23-kernel-4.9 (test-1.23-4.9)
  • k8s-1.24-kernel-4.9 (test-1.24-4.9)

Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐧

@joestringer joestringer merged commit 42b8d75 into cilium:v1.13 Apr 18, 2023
40 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants