Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation: move policy warning to v1.13.2 section #24997

Merged
merged 1 commit into from
Apr 21, 2023

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Apr 20, 2023

Poor timing with documentation updates meant this was in the 1.13.1 section, but the bug is present in v1.13.2 as well.

Poor timing with documentation updates meant this was in the 1.13.1
section, but the bug is present in v1.13.2 as well.

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed added the release-note/misc This PR makes changes that have no direct user impact. label Apr 20, 2023
@squeed squeed requested a review from a team as a code owner April 20, 2023 10:45
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels Apr 20, 2023
@squeed
Copy link
Contributor Author

squeed commented Apr 20, 2023

note: this isn't really a backport, per se, just a tweak of the upgrade notes.

@ldelossa
Copy link
Contributor

Tangential to this PR, but the updated file seems to hit a gap in Codeowners and did not trigger the @cilium/docs-structure group for review.

/Documentation/observability/ @cilium/sig-policy @cilium/docs-structure

Do we want to fix this situation?

@ldelossa
Copy link
Contributor

Scratch that comment, @michi-covalent made me aware that codeowner file is different for stable branches, which we are merging into.

You can disregard.

@joestringer
Copy link
Member

docs-only change, docs target passed, tophat review in. Can be merged.

@joestringer joestringer added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 20, 2023
@ldelossa ldelossa merged commit 72b21af into cilium:v1.13 Apr 21, 2023
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants