Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ingress id backport 1.13 #25019

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Ingress id backport 1.13 #25019

merged 2 commits into from
Apr 25, 2023

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented Apr 20, 2023 •
edited

Once this PR is merged, you can update the PR labels via:

for pr in 24826; do contrib/backporting/set-labels.py $pr done 1.13; done

or with

make add-labels BRANCH=v1.13 ISSUES=24826

@jrajahalme jrajahalme added kind/backports This PR provides functionality previously merged into master. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels Apr 20, 2023
@jrajahalme jrajahalme requested a review from a team as a code owner April 20, 2023 18:58
@jrajahalme jrajahalme marked this pull request as draft April 20, 2023 18:58
@jrajahalme
Copy link
Member Author

/test-backport-1.13

@sayboras
Copy link
Member

/test-1.18-4.19

@sayboras
Copy link
Member

/test-1.21-4.19

@sayboras
Copy link
Member

/test-1.26-net-next

@jrajahalme
envoy: Update to support Ingress identity for local sources
00606e9 
[ upstream commit f94351b ]

Some Envoy API fields were renamed for clarity.

Update Envoy image and API to revert Envoy TcpPorxy API change done
earlier in cilium/proxy patches to support WebSocket handshake with the
TcpProxy filter. This change is now replaced with a dynamic metadata
method that is invisible to the Envoy API.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme
envoy: pass 'useOriginalSourceAddr' parameter through ParseResources()
ad8b32a 
[ upstream commit 01a0367 ]

Add 'useOriginalSourceAddr' parameter to ParseResources() to inform if
the listener should use original source address or not. Pass this as
'true' from C/CEC watchers if OwnerReferences does not contain
Kind=Ingress. That is, do not use original source addressing for Ingress
listeners. This makes upstream connections from Ingress listeners to use
node's allocated Ingress addresses in all cases, so that the source if
Ingress traffic within the cluster is seen as 'ReservedIdentityIngress'
(8).

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme
Copy link
Member Author

/test-backport-1.13

@jrajahalme jrajahalme marked this pull request as ready for review April 25, 2023 15:17
@michi-covalent michi-covalent mentioned this pull request Apr 25, 2023
Merged
@jrajahalme
Copy link
Member Author

/test-1.16-4.19

@jrajahalme
Copy link
Member Author

/test-1.18-4.19

@jrajahalme
Copy link
Member Author

/test-1.19-4.19

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 25, 2023
@michi-covalent michi-covalent merged commit a5d8e5d into cilium:v1.13 Apr 25, 2023
60 of 61 checks passed
@thorn3r thorn3r mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. ready-to-merge This PR has passed all tests and received consensus from code owners to merge.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrajahalme @sayboras @michi-covalent