Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove STATUS commands from upstream tests' Jenkinsfile #25046

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

nbusseneau
Copy link
Member

@nbusseneau nbusseneau commented Apr 21, 2023

These are remnants of a past before GHPRB. At best they create uncessary noise in the logs, at worst they can interfere with the default behaviour, so let's just remove them.

These are remnants of a past before GHPRB. At best they create
uncessary noise in the logs, at worst they can interfere with the
default behaviour, so let's just remove them.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Apr 21, 2023
@nbusseneau
Copy link
Member Author

/test-upstream-k8s

@pchaigno
Copy link
Member

I've included this commit in #25044.

@nbusseneau nbusseneau added needs-backport/1.11 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.11.17 Apr 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.3 Apr 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.10 Apr 26, 2023
@nbusseneau nbusseneau marked this pull request as ready for review April 26, 2023 12:01
@nbusseneau nbusseneau requested a review from a team as a code owner April 26, 2023 12:01
@nbusseneau
Copy link
Member Author

nbusseneau commented Apr 26, 2023

The CI failed "as expected" (i.e. it timed out and correctly reported back as a failure on GH commit status API, which is the intended behaviour and fixing the unintended behaviour currently in main where it instead was reporting back as successful). Also, this commit was tested as part of the revert in #25044. I think we are good to merge.

@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Apr 26, 2023
@pchaigno pchaigno merged commit 46de5bc into cilium:main Apr 26, 2023
44 of 45 checks passed
@sayboras sayboras mentioned this pull request Apr 26, 2023
7 tasks
@sayboras sayboras added the backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. label Apr 26, 2023
@sayboras sayboras mentioned this pull request Apr 26, 2023
2 tasks
@sayboras sayboras mentioned this pull request Apr 26, 2023
2 tasks
@sayboras sayboras added backport-pending/1.11 backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. backport-pending/1.12 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Apr 26, 2023
@sayboras sayboras removed the backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. label Apr 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport done to v1.13 in 1.13.3 Apr 28, 2023
@sayboras sayboras moved this from Needs backport from main to Backport done to v1.12 in 1.12.10 Apr 28, 2023
@sayboras sayboras moved this from Needs backport from main to Backport pending to v1.11 in 1.11.17 Apr 28, 2023
@joamaki joamaki mentioned this pull request May 3, 2023
8 tasks
@joamaki joamaki added backport-pending/1.12 and removed backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. needs-backport/1.12 labels May 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport done to v1.12 to Backport pending to v1.12 in 1.12.10 May 3, 2023
@joamaki joamaki mentioned this pull request May 3, 2023
8 tasks
@jrajahalme jrajahalme added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels May 12, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.11 to Backport done to v1.11 in 1.11.17 May 12, 2023
@julianwiedmann julianwiedmann added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jul 10, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.10 Jul 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.11.17
Backport done to v1.11
1.12.10
Backport done to v1.12
1.13.3
Backport done to v1.13
Development

Successfully merging this pull request may close these issues.

None yet

6 participants