Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed documentation regarding cilium versioning scheme and support #25171

Merged
merged 1 commit into from
May 2, 2023
Merged

Fixed documentation regarding cilium versioning scheme and support #25171

merged 1 commit into from
May 2, 2023

Conversation

ayesha-kr
Copy link
Contributor

@ayesha-kr ayesha-kr commented Apr 27, 2023 •
edited

Cilium follows major.minor.patch version scheme. The section on ReadMe telling about the end of support is incorrect. This PR is fixing it.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

@ayesha-kr ayesha-kr requested a review from a team as a code owner April 27, 2023 18:17
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Apr 27, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Apr 27, 2023
@ayesha-kr ayesha-kr mentioned this pull request Apr 27, 2023
Closed
8 tasks
@maintainer-s-little-helper
Copy link

Commit 51974c2a02cd3e0db23c67d38fea96d24adea251 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 27, 2023
@maintainer-s-little-helper
Copy link

Commits 51974c2a02cd3e0db23c67d38fea96d24adea251, e663cd38e6ba8a07462e151f79eb355c9022cb4a do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper
Copy link

Commits 51974c2a02cd3e0db23c67d38fea96d24adea251, e663cd38e6ba8a07462e151f79eb355c9022cb4a, 0976b024a85578776a90f8b8adc751c4cfbdbf0b do not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@ayesha-kr
Fixed documentation regarding cilium versioning scheme and support
999484c 
Cilium follows major.minor.patch version scheme. The section on ReadMe telling about the end of support is incorrect. This PR is fixing it.

Signed-off-by: ayesha khaliq <ayeshakhaliqrana@gmail.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Apr 27, 2023
@zacharysarah zacharysarah added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Apr 28, 2023
zacharysarah
zacharysarah approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@zacharysarah zacharysarah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ayesha-kr Thanks for the fix! Please be sure to add a release note label to the PR so it can merge.

@ayesha-kr
Copy link
Contributor Author

@ayesha-kr Thanks for the fix! Please be sure to add a release note label to the PR so it can merge.

Thanks for approval @zacharysarah
I actually tried inserting the label release-note/misc but I am unable to edit the labels section of this PR

image
Do we add it differently? It's my first commit so apologies if I am unaware of it.

@pchaigno pchaigno added the release-note/misc This PR makes changes that have no direct user impact. label May 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 1, 2023
@joestringer joestringer added the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label May 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.3 May 2, 2023
@joestringer joestringer merged commit 4cd06e4 into cilium:main May 2, 2023
43 checks passed
@joestringer
Copy link
Member

Thanks for the fix!

@joamaki joamaki mentioned this pull request May 2, 2023
Merged
8 tasks
@joamaki joamaki added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.3 May 2, 2023
@julianwiedmann julianwiedmann added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels May 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.3 May 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.3 May 9, 2023
@thorn3r thorn3r mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zacharysarah zacharysarah zacharysarah approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. kind/community-contribution This was a contribution made by a community member. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.13.3
Backport done to v1.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ayesha-kr @joestringer @zacharysarah @joamaki @pchaigno @julianwiedmann