-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add github workflow to push development helm charts to quay.io #25205
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like the fact that it's neatly kept in separate files ❤️
Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
12a043b
to
a807982
Compare
Okay, I updated it to use a few more variables in case we want to reuse this elsewhere. CI run: https://github.com/cilium/cilium/actions/runs/4835002365/jobs/8616858840 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very nice!
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test Name
Failure Output
Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/2054/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
There's nothing to test in this PR @michi-covalent |
i'm keeping it simple. if the button is not green, i don't merge ✅ |
test-1.26-net-next: hit #15455 |
/test-1.26-net-next |
is the button green? yes. am i merging it? definitely. |
The goal of this PR is to make it easier for developers and users to test images prior to releases being tagged. A common source of trouble is using images built in CI with the wrong version of the helm chart. This usually occurs when someone is testing an image from CI with the latest release of the chart. Typically this results in a failed install because the older chart is incompatible with the newer image.
This can simplify the testing of new changes by building a chart whenever an image is built, updating the chart to use the images built in CI. This means you can just install the chart, no need to even modify your values.yaml to use the CI images.
This was tested in a separate branch since
workflow_dispatch
only will work for workflows in the default branch. The CI ran passed here: https://github.com/cilium/cilium/actions/runs/4834815876. Normally it will only run after the image build CI workflow finishes, and or if triggered manually.Once the chart is pushed, you can use it with helm like so:
You can view the chart repo here: https://quay.io/repository/cilium-charts-dev/cilium?tab=tags