Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github workflow to push development helm charts to quay.io #25205

Merged
merged 1 commit into from
May 4, 2023

Conversation

chancez
Copy link
Contributor

@chancez chancez commented Apr 28, 2023

The goal of this PR is to make it easier for developers and users to test images prior to releases being tagged. A common source of trouble is using images built in CI with the wrong version of the helm chart. This usually occurs when someone is testing an image from CI with the latest release of the chart. Typically this results in a failed install because the older chart is incompatible with the newer image.

This can simplify the testing of new changes by building a chart whenever an image is built, updating the chart to use the images built in CI. This means you can just install the chart, no need to even modify your values.yaml to use the CI images.

This was tested in a separate branch since workflow_dispatch only will work for workflows in the default branch. The CI ran passed here: https://github.com/cilium/cilium/actions/runs/4834815876. Normally it will only run after the image build CI workflow finishes, and or if triggered manually.

Once the chart is pushed, you can use it with helm like so:

helm template -n kube-system oci://quay.io/cilium-charts-dev/cilium --version 1.13.90-dev.426-ft-main-chancez-push-dev-charts-76b0a5c283
helm install cilium -n kube-system oci://quay.io/cilium-charts-dev/cilium --version 1.13.90-dev.426-ft-main-chancez-push-dev-charts-76b0a5c283 --dry-run

You can view the chart repo here: https://quay.io/repository/cilium-charts-dev/cilium?tab=tags

@chancez chancez added the release-note/ci This PR makes changes to the CI. label Apr 28, 2023
@chancez chancez requested review from a team as code owners April 28, 2023 21:12
@chancez chancez self-assigned this Apr 28, 2023
Copy link
Contributor

@michi-covalent michi-covalent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i like the fact that it's neatly kept in separate files ❤️

Signed-off-by: Chance Zibolski <chance.zibolski@gmail.com>
@chancez chancez force-pushed the pr/main/chancez/push-dev-charts branch from 12a043b to a807982 Compare April 28, 2023 21:40
@chancez
Copy link
Contributor Author

chancez commented Apr 28, 2023

Okay, I updated it to use a few more variables in case we want to reuse this elsewhere. CI run: https://github.com/cilium/cilium/actions/runs/4835002365/jobs/8616858840

Copy link
Contributor

@viktor-kurchenko viktor-kurchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

.github/actions/set-env-variables/action.yml Show resolved Hide resolved
@michi-covalent
Copy link
Contributor

michi-covalent commented May 3, 2023

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks N/S loadbalancing With host policy Tests NodePort

Failure Output

FAIL: Can not connect to service "tftp://[fd04::12]:31990/hello" from outside cluster (1/10)

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/2054/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

@chancez
Copy link
Contributor Author

chancez commented May 3, 2023

There's nothing to test in this PR @michi-covalent

@michi-covalent
Copy link
Contributor

i'm keeping it simple. if the button is not green, i don't merge ✅

@michi-covalent
Copy link
Contributor

test-1.26-net-next: hit #15455

@michi-covalent
Copy link
Contributor

/test-1.26-net-next

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 4, 2023
@michi-covalent
Copy link
Contributor

is the button green? yes. am i merging it? definitely.

@michi-covalent michi-covalent merged commit d90803c into main May 4, 2023
56 checks passed
@michi-covalent michi-covalent deleted the pr/main/chancez/push-dev-charts branch May 4, 2023 03:14
@joestringer joestringer added backport-pending/1.12 backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jun 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.12 in 1.12.10 Jun 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.13 in 1.13.3 Jun 9, 2023
@joestringer joestringer added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jun 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.3 Jun 9, 2023
@joestringer joestringer added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels Jun 9, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.10 Jun 9, 2023
@joestringer joestringer added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.12.10
Backport done to v1.12
1.13.3
Backport done to v1.13
Development

Successfully merging this pull request may close these issues.

None yet

5 participants