Fix possible panic in the ipcache when removing the prefix labels for an unknown resource ID #25230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a sanity check to avoid accessing the ipcache metadata map entry for a given prefix during removal if the corresponding resource ID was not present, since that would cause a panic. Signed-off-by: Marco Iorio <marco.iorio@isovalent.com>
giorio94
added
kind/bug
|
/test |
christarazi
approved these changes
May 2, 2023
gandro
approved these changes
May 3, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
14 tasks
YutaroHayakawa
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.3
julianwiedmann
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a sanity check to avoid accessing the ipcache metadata map entry for a given prefix during removal if the corresponding resource ID was not present, since that would cause a panic.
Marking with
release-note/miscsince I'm not sure whether this bug could happen with "legitimate" usage. I experienced it after creating a custom endpointslice for the kubernetes service for testing purposes.