bpf: nat: fix ICMPv6 ECHO types in snat_v6_rewrite_ingress() #25306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When revSNATing ICMPv6 packets, check for the ICMPv6 type identifiers. Fixes: 0759290 ("bpf/nat: review snat_v{4|6}_rewrite_ingress to support more ICMP types") Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
kind/bug
|
/test Job 'Cilium-PR-K8s-1.16-kernel-4.19' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.16-kernel-4.19/1310/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
sahid
approved these changes
May 8, 2023
ldelossa
approved these changes
May 12, 2023
|
Re-running the failed CI job, it's already gone after 4 days 🤨 |
|
/test-1.16-4.19 |
maintainer-s-little-helper
bot
added
the
ready-to-merge
jibi
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.3
jibi
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.3
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When revSNATing ICMPv6 packets, check for the ICMPv6 type identifiers.
Fixes: 0759290 ("bpf/nat: review snat_v{4|6}_rewrite_ingress to support more ICMP types")