-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: socketLB.hostNamespaceOnly
also needed for gVisor
#25322
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
release-note/misc
This PR makes changes that have no direct user impact.
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
labels
May 8, 2023
jibi
approved these changes
May 9, 2023
pchaigno
force-pushed
the
docs-gvisor-skip-socket-lb
branch
from
May 9, 2023 09:46
c8b46b6
to
ed2369d
Compare
We confirmed with a user that socketLB.hostNamespaceOnly=true is also needed for gVisor when using KPR=strict. gVisor otherwise faces the same issue as KubeVirt or Kata containers. Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
pchaigno
force-pushed
the
docs-gvisor-skip-socket-lb
branch
from
May 9, 2023 09:46
ed2369d
to
5071ad8
Compare
pchaigno
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
May 9, 2023
JAORMX
approved these changes
May 9, 2023
qmonnet
approved these changes
May 9, 2023
@pchaigno: It seems like your email in your SOB is different from the usual one, is it intentional? |
Yeah, I think I changed the global or something. |
14 tasks
YutaroHayakawa
added
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
and removed
needs-backport/1.13
This PR / issue needs backporting to the v1.13 branch
labels
May 10, 2023
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.3
May 10, 2023
pchaigno
added
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
and removed
backport-pending/1.13
The backport for Cilium 1.13.x for this PR is in progress.
labels
Jun 20, 2023
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.3
Jun 20, 2023
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.3
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
Impacts the documentation, including textual changes, sphinx, or other doc generation code.
backport-done/1.13
The backport for Cilium 1.13.x for this PR is done.
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We confirmed with a user that
socketLB.hostNamespaceOnly=true
is also needed for gVisor when using KPR=strict. gVisor otherwise faces the same issue as KubeVirt or Kata containers.