Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: socketLB.hostNamespaceOnly also needed for gVisor #25322

Merged
merged 1 commit into from
May 9, 2023

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented May 8, 2023

We confirmed with a user that socketLB.hostNamespaceOnly=true is also needed for gVisor when using KPR=strict. gVisor otherwise faces the same issue as KubeVirt or Kata containers.

@pchaigno pchaigno added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 8, 2023
@pchaigno pchaigno requested review from a team as code owners May 8, 2023 18:35
@pchaigno pchaigno requested a review from jibi May 8, 2023 18:35
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.3 May 8, 2023
@pchaigno pchaigno force-pushed the docs-gvisor-skip-socket-lb branch from c8b46b6 to ed2369d Compare May 9, 2023 09:46
We confirmed with a user that socketLB.hostNamespaceOnly=true is also
needed for gVisor when using KPR=strict. gVisor otherwise faces the same
issue as KubeVirt or Kata containers.

Signed-off-by: Paul Chaignon <paul.chaignon@gmail.com>
@pchaigno pchaigno force-pushed the docs-gvisor-skip-socket-lb branch from ed2369d to 5071ad8 Compare May 9, 2023 09:46
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 9, 2023
@qmonnet
Copy link
Member

qmonnet commented May 9, 2023

@pchaigno: It seems like your email in your SOB is different from the usual one, is it intentional?

@pchaigno
Copy link
Member Author

pchaigno commented May 9, 2023

It seems like your email in your SOB is different from the usual one, is it intentional?

Yeah, I think I changed the global or something.

@youngnick youngnick merged commit c5d3093 into cilium:main May 9, 2023
36 checks passed
@pchaigno pchaigno deleted the docs-gvisor-skip-socket-lb branch May 9, 2023 16:45
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 10, 2023
14 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 10, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.3 May 10, 2023
@pchaigno pchaigno added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jun 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.3 Jun 20, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.3 Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.13.3
Backport done to v1.13
Development

Successfully merging this pull request may close these issues.

None yet

6 participants