hostfw tests flake workaround #25323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
tommyp1ckles
changed the title
tommyp1ckles
force-pushed
the
pr/tp/hostfw-tests-flake-workaround
branch
2 times, most recently
from
ab813bd
to
7ab0d4e
Compare
tommyp1ckles
added
area/CI
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
First see the code comments for the full explanation.
This issue with the faulty conntrack entries when enforcing host
policies is suspected to cause the flakes that have been polluting host
firewall tests. We've seen this faulty conntrack issue happen mostly to
health and kube-apiserver connections. And it turns out that the host
firewall flakes look like they are caused by connectivity blips on
kube-apiserver's side, which error messages such as:
error: unable to upgrade connection: Authorization error (user=kube-apiserver-kubelet-client, verb=create, resource=nodes, subresource=proxy)
This commit therefore tries to workaround the issue of faulty conntrack
entries in host firewall tests. If the flakes are indeed caused by those
faulty entries, we shouldn't see them happen anymore.
Signed-off-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
tommyp1ckles
force-pushed
the
pr/tp/hostfw-tests-flake-workaround
branch
from
7ab0d4e
to
2b38775
Compare
pchaigno
approved these changes
May 8, 2023
gentoo-root
approved these changes
May 8, 2023
|
/test |
pchaigno
added
the
ready-to-merge
pchaigno
added
needs-backport/1.11
needs-backport/1.13
|
Marking this for backports everywhere as it's a fairly frequent flake that happens on all branches (I've seen reports on v1.10 backport PRs) and I expect it to be trivial to backport. |
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.12
in 1.12.10
tklauser
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.3
tklauser
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.10
tklauser
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.3
This was referenced Jun 9, 2023
julianwiedmann
added
backport-done/1.11
julianwiedmann
added
the
area/host-firewall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopening #25199 as the issue continuous to plague our CI.
For reviewers: With this change, we want to further confirm suspicions relating to #15455 that these flakes are caused by this issue.
Currently, this issue is by-far the largest cause of failures in our CI, what we're interested in seeing if this significantly affects that.