test/k8s: for services test, wait for all applied manifests to delete #25341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
|
/test |
tommyp1ckles
force-pushed
the
pr/tp/wait-for-k8s-services-test-yaml-delete
branch
from
5d799d2
to
a269d79
Compare
|
/test |
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
tommyp1ckles
force-pushed
the
pr/tp/wait-for-k8s-services-test-yaml-delete
branch
from
a269d79
to
caf857e
Compare
|
/test |
tommyp1ckles
force-pushed
the
pr/tp/wait-for-k8s-services-test-yaml-delete
branch
from
caf857e
to
8f506a8
Compare
|
/test |
qmonnet
approved these changes
May 10, 2023
nebril
approved these changes
May 10, 2023
tommyp1ckles
force-pushed
the
pr/tp/wait-for-k8s-services-test-yaml-delete
branch
from
8f506a8
to
a06c785
Compare
|
/test |
1 similar comment
|
/test |
|
bunch of failures from GH outages, will merge once I'm convinced everything relevant is passing. |
|
/test |
In the K8sDatapathConfig tests "echo-svc" deployment Pods are failing to terminate while waiting to terminate all Pods. These come from a deployment, that shouldn't be applied in this suite. Presumably failure to delete is being cause by the Deployment controller restarting the Pods as they're deleted. To try to fix this, going to wait for applied yamls in K8sServices to be fully deleted, including finalizers. Addresses: cilium#25255 Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
tommyp1ckles
force-pushed
the
pr/tp/wait-for-k8s-services-test-yaml-delete
branch
from
a06c785
to
3cfe858
Compare
|
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/2214/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
|
Go unit tests hit: #25353 - theres a PR open to fix. |
|
/test-1.16-4.19 |
|
/test-1.26-net-next |
tommyp1ckles
added
the
needs-backport/1.13
jibi
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.3
jibi
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.3
This was referenced Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the K8sDatapathConfig tests "echo-svc" deployment Pods are failing to terminate while waiting to terminate all Pods. These come from a deployment, that don't appear to be used in this suite. Presumably failure to delete is being cause by the Deployment controller restarting the Pods as they're deleted.
To try to fix this, going to wait for applied yamls in K8sServices to be fully deleted, including finalizers.
Addresses: #25255