Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/provision/compile.sh: Make usable from dev VM #25352

Merged
merged 1 commit into from
May 12, 2023

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented May 10, 2023

Add missing 'sudo' commands so that this can be run from a shell in a dev VM to launch a local cilium agent in docker.

Only install the bpf mount unit to systemd if not already mounted. This avoids error message like this:

Unit sys-fs-bpf.mount has a bad unit file setting

With these changes Cilium agent can be compiled and launced in docker, assuming the VM hostname does NOT include "k8s", like so:

$ SKIP_TEST_IMAGE_DOWNLOAD=1 VMUSER=${USER} PROVISIONSRC=test/provision test/provision/compile.sh

After this 'docker ps' should show a "cilium" container.

This can be used, for example to quickly run Cilium agent locally to observer agent startup and exit logs via 'docker logs cilium -f' when stopping cilium with 'docker stop cilium'.

@jrajahalme jrajahalme added the release-note/misc This PR makes changes that have no direct user impact. label May 10, 2023
@jrajahalme jrajahalme requested a review from a team as a code owner May 10, 2023 11:44
@jrajahalme jrajahalme requested a review from nebril May 10, 2023 11:44
Add missing 'sudo' commands so that this can be run from a shell in a dev
VM to launch a local cilium agent in docker.

Only install the bpf mount unit to systemd if not already mounted. This
avoids error message like this:

    Unit sys-fs-bpf.mount has a bad unit file setting

With these changes Cilium agent can be compiled and launced in docker,
assuming the VM hostname does NOT include "k8s", like so:

   $ SKIP_TEST_IMAGE_DOWNLOAD=1 VMUSER=${USER} PROVISIONSRC=test/provision test/provision/compile.sh

After this 'docker ps' should show a "cilium" container.

This can be used, for example to quickly run Cilium agent locally to
observer agent startup and exit logs via 'docker logs cilium -f' when
stopping cilium with 'docker stop cilium'.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme
Copy link
Member Author

jrajahalme commented May 10, 2023

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks N/S loadbalancing Tests with XDP, direct routing, DSR and Maglev

Failure Output

FAIL: Can not connect to service "tftp://[fd04::11]:31364/hello" from outside cluster (10/10)

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/2197/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

@jrajahalme
Copy link
Member Author

/test-1.26-net-next

@jrajahalme jrajahalme added needs-backport/1.11 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 12, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.3 May 12, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.10 May 12, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.11.17 May 12, 2023
@jrajahalme jrajahalme merged commit 0112ddb into cilium:main May 12, 2023
44 of 45 checks passed
@jrajahalme jrajahalme added this to Needs backport from main in 1.11.18 May 12, 2023
@jrajahalme jrajahalme removed this from Needs backport from main in 1.11.17 May 12, 2023
@gentoo-root gentoo-root mentioned this pull request May 12, 2023
3 tasks
@jibi jibi mentioned this pull request May 15, 2023
3 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.12 in 1.12.10 May 15, 2023
@jibi jibi mentioned this pull request May 17, 2023
7 tasks
@jibi jibi added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from main to Backport pending to v1.13 in 1.13.3 May 17, 2023
@jibi jibi mentioned this pull request May 19, 2023
2 tasks
@jibi jibi added backport-pending/1.11 backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed needs-backport/1.11 labels May 19, 2023
@jibi jibi removed the backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. label May 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.3 May 23, 2023
@joestringer joestringer added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. and removed backport-pending/1.12 labels May 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.10 May 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.12 to Backport done to v1.12 in 1.12.10 May 26, 2023
@michi-covalent michi-covalent added this to Backport pending to v1.11 in 1.11.19 Jun 14, 2023
@michi-covalent michi-covalent removed this from Needs backport from main in 1.11.18 Jun 14, 2023
@julianwiedmann julianwiedmann added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jul 11, 2023
@gentoo-root gentoo-root moved this from Backport pending to v1.11 to Backport done to v1.11 in 1.11.19 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.11.19
Backport done to v1.11
1.12.10
Backport done to v1.12
1.13.3
Backport done to v1.13
Development

Successfully merging this pull request may close these issues.

None yet

5 participants