Slim down Node handler interface #25450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
bimmlerd
added
release-note/misc
bimmlerd
force-pushed
the
pr/bimmlerd/node-handler-diet
branch
from
475cba0
to
440cb74
Compare
bimmlerd
requested review from
brb,
thorn3r,
jrajahalme,
chancez and
YutaroHayakawa
chancez
approved these changes
May 15, 2023
gandro
approved these changes
May 16, 2023
|
/test |
bimmlerd
force-pushed
the
pr/bimmlerd/node-handler-diet
branch
from
440cb74
to
28b58b6
Compare
|
Rebased as this picked up a conflict with upstream. |
|
/test |
christarazi
added
kind/cleanup
YutaroHayakawa
approved these changes
May 24, 2023
sayboras
added
the
needs-backport/1.13
This was referenced Jun 6, 2023
2 tasks
bimmlerd
added
backport-pending/1.13
2 tasks
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.12
in 1.12.10
2 tasks
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.11
in 1.11.18
This was referenced Jun 9, 2023
michi-covalent
added
backport-done/1.12
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.10
maintainer-s-little-helper
bot
moved this from Backport pending to v1.12
to Backport done to v1.12
in 1.12.10
michi-covalent
added
backport-done/1.11
maintainer-s-little-helper
bot
moved this from Backport pending to v1.11
to Backport done to v1.11
in 1.11.18
julianwiedmann
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review commit by commit, though changes shouldn't be too large
I was looking into
NodeHandlerfor a related PR, and noticed that one has to stub out quite a few methods to implement the interface, even if the code is just interested in getting notifed onNode{Add,Update,Delete}. That seemed suboptimal, so this series splits theNodeHandlerinterface in three more focussed interfaces. Purely cosmetic change, no (intentional) functional changes.A next step might be to look into breaking up the
linuxNodeHandler, but that's stuff for another PR.cc @gandro