Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.13] Update CNI to 1.3.0 #25454

Merged
merged 2 commits into from
May 16, 2023
Merged

[v1.13] Update CNI to 1.3.0 #25454

merged 2 commits into from
May 16, 2023

Conversation

thorn3r
Copy link
Contributor

@thorn3r thorn3r commented May 15, 2023 •
edited

v1.13 backports 2023-05-12

Once this PR is merged, you can update the PR labels via:

$ for pr in 25400; do contrib/backporting/set-labels.py $pr done 1.13; done

@anfernee @thorn3r
Update CNI to 1.3.0
740083b 
Run `images/scripts/update-cni-version.sh 1.3.0` to update the CNI
version.

Ref: https://github.com/containernetworking/plugins/releases/tag/v1.3.0
Signed-off-by: Yongkun Gui <ygui@google.com>
@thorn3r thorn3r requested a review from a team as a code owner May 15, 2023 13:54
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels May 15, 2023
@thorn3r thorn3r had a problem deploying to release-base-images May 15, 2023 13:54 — with GitHub Actions Failure
@thorn3r
images: update cilium-{runtime,builder}
91ed38d 
Signed-off-by: Tim Horner <timothy.horner@isovalent.com>
@thorn3r thorn3r requested review from a team as code owners May 15, 2023 14:56
@thorn3r thorn3r requested review from gandro, aanm and tklauser May 15, 2023 14:56
@thorn3r thorn3r temporarily deployed to release-base-images May 15, 2023 14:56 — with GitHub Actions Inactive
@thorn3r
Copy link
Contributor Author

thorn3r commented May 15, 2023

/test-backport-1.13

@joestringer
Copy link
Member

When doing manual backports of PRs, please follow https://docs.cilium.io/en/v1.13/contributing/release/backports/#via-github-web-interface - this ensures that the release notes properly pick up the related changes.

@joestringer
Copy link
Member

I've approved the base images build.

@joestringer
Copy link
Member

@thorn3r The CI trigger doesn't seem like it has taken effect, I don't see the Details link beside the various ginkgo jobs 🤔 Maybe try once more?

@thorn3r
Copy link
Contributor Author

thorn3r commented May 15, 2023

/test-backport-1.13

@thorn3r
Copy link
Contributor Author

thorn3r commented May 15, 2023

@joestringer trying again 🤞

@joestringer
Copy link
Member

That's weird, the GitHub action based workflows seemed to trigger, but the jenkins+ginkgo ones did not.

@joestringer
Copy link
Member

joestringer commented May 15, 2023 •
edited by maintainer-s-little-helper bot

/test-backport-1.13

Job 'Cilium-PR-K8s-1.25-kernel-4.19' hit: #25255 (88.79% similarity)

Job 'Cilium-PR-K8s-1.20-kernel-4.19' failed:

Click to show.

Test Name

K8sAgentPolicyTest Multi-node policy test with L7 policy using connectivity-check to check datapath

Failure Output

FAIL: connectivity-check pods are not ready after timeout

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.20-kernel-4.19/1937/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.20-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

@joestringer
Copy link
Member

They triggered when I ran it, so there must be something about your user that's not configured right in the Cilium CI systems. Worth following up with the testing folks to find out why that's the case. You're an org member (part of the Team team), so I assumed you should be able to trigger those workflows.

@christarazi christarazi changed the title Update CNI to 1.3.0 [v1.13] Update CNI to 1.3.0 May 15, 2023
@thorn3r
Copy link
Contributor Author

thorn3r commented May 15, 2023

/ci-gke-1.13

@thorn3r
Copy link
Contributor Author

thorn3r commented May 15, 2023

/test-1.16-4.19

@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request May 15, 2023
Closed
@thorn3r
Copy link
Contributor Author

thorn3r commented May 15, 2023

/test-1.25-4.19

@thorn3r
Copy link
Contributor Author

thorn3r commented May 15, 2023

k8s-1.25-kernel-4.19 (test-1.25-4.19) looks related to this flake: K8sVerifier Runs the kernel verifier against Cilium's BPF datapath. re-running

@thorn3r
Copy link
Contributor Author

thorn3r commented May 15, 2023

/test-1.25-4.19

@thorn3r
Copy link
Contributor Author

thorn3r commented May 15, 2023

failure for k8s-1.25-kernel-4.19 (test-1.25-4.19) looks like it could be related to #22749

@asauber
Copy link
Member

asauber commented May 15, 2023

/test-1.20-4.19

@aditighag
Copy link
Member

/test-1.25-4.19

@thorn3r thorn3r mentioned this pull request May 15, 2023
Merged
1 task
@aanm aanm merged commit 7ffe951 into cilium:v1.13 May 16, 2023
64 checks passed
@thorn3r thorn3r mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanm aanm aanm approved these changes

@gandro gandro Awaiting requested review from gandro gandro is a code owner automatically assigned from cilium/sig-hubble-api

@tklauser tklauser Awaiting requested review from tklauser tklauser is a code owner automatically assigned from cilium/ci-structure

Assignees
No one assigned
Labels
backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@thorn3r @joestringer @asauber @aditighag @aanm @anfernee