Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/k8s: add host firewall workaround for svc host policy test. #25461

Merged
merged 1 commit into from
May 17, 2023
Merged

test/k8s: add host firewall workaround for svc host policy test. #25461

merged 1 commit into from
May 17, 2023

Conversation

tommyp1ckles
Copy link
Contributor

Change 439a0a0 introduced workaround to common flake we've been seeing relating to issue #15455.

Any test enabling hostfw/host-policy will may suffer from the same issue.

Addresses: #25411

@tommyp1ckles
test/k8s: add host firewall workaround for svc host policy test.
0e20d30 
Change 439a0a0 introduced workaround to common flake we've been seeing relating to issue cilium#15455.

Any test enabling hostfw/host-policy will may suffer from the same issue.

Addresses: cilium#25411

Signed-off-by: Tom Hadlaw <tom.hadlaw@isovalent.com>
@tommyp1ckles tommyp1ckles requested review from a team as code owners May 15, 2023 17:51
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 15, 2023
@tommyp1ckles tommyp1ckles added the release-note/ci This PR makes changes to the CI. label May 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 15, 2023
@pchaigno pchaigno added the area/host-firewall Impacts the host firewall or the host endpoint. label May 15, 2023
@tommyp1ckles
Copy link
Contributor Author

/test

@pchaigno
Copy link
Member

/test-vagrant

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 17, 2023
@pchaigno
Copy link
Member

Reviewed and passes impacted tests. We can merge. cc @brb

@pchaigno pchaigno added the needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch label May 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.3 May 17, 2023
@aditighag aditighag merged commit 0cfce97 into cilium:main May 17, 2023
50 checks passed
@thorn3r thorn3r added this to Needs backport from main in 1.13.4 May 17, 2023
@thorn3r thorn3r removed this from Needs backport from main in 1.13.3 May 17, 2023
@tklauser tklauser mentioned this pull request May 22, 2023
Merged
4 tasks
@tklauser tklauser added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 22, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.13 in 1.13.3 May 22, 2023
@tklauser tklauser added backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels May 26, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.13 to Backport done to v1.13 in 1.13.3 May 26, 2023
@qmonnet qmonnet moved this from Needs backport from main to Backport done to v1.13 in 1.13.4 Jun 9, 2023
@qmonnet qmonnet mentioned this pull request Jun 9, 2023
Closed
@michi-covalent michi-covalent mentioned this pull request Jun 9, 2023
Closed
@michi-covalent michi-covalent mentioned this pull request Jun 14, 2023
Merged
@pchaigno pchaigno mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@christarazi christarazi christarazi approved these changes

@jibi jibi Awaiting requested review from jibi jibi is a code owner automatically assigned from cilium/sig-lb

Assignees
No one assigned
Labels
area/host-firewall Impacts the host firewall or the host endpoint. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
No open projects
1.13.3
Backport done to v1.13
1.13.4
Backport done to v1.13
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tommyp1ckles @pchaigno @christarazi @tklauser @aditighag