Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

daemon: Don't register monitor listener for auth required events #25548

Merged
merged 1 commit into from
May 23, 2023
Merged

daemon: Don't register monitor listener for auth required events #25548

merged 1 commit into from
May 23, 2023

Conversation

jrajahalme
Copy link
Member

Auth required events are not handled in v1.13, so don't add the monitor listener to avoid the associated overhead.

CPU overhead regression introduced in v1.13 is fixed.

@jrajahalme
daemon: Don't register monitor listener for auth required events
d105467 
Auth required events are not handled in v1.13, so don't add the monitor
listener to avoid the associated overhead.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme added kind/performance There is a performance impact of this. release-note/bug This PR fixes an issue in a previous release of Cilium. labels May 19, 2023
@jrajahalme jrajahalme requested a review from pchaigno May 19, 2023 09:48
@jrajahalme jrajahalme requested a review from a team as a code owner May 19, 2023 09:48
@maintainer-s-little-helper maintainer-s-little-helper bot added backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. labels May 19, 2023
@jrajahalme jrajahalme added release-blocker/1.13 This issue will prevent the release of the next version of Cilium. affects/v1.13 This issue affects v1.13 branch labels May 19, 2023
@jrajahalme
Copy link
Member Author

/test-backport-1.13

@jrajahalme
Copy link
Member Author

/test-backport-1.13

2 similar comments
@pchaigno
Copy link
Member

/test-backport-1.13

@jrajahalme
Copy link
Member Author

/test-backport-1.13

@jrajahalme
Copy link
Member Author

/test-1.26-net-next

@aanm aanm removed the release-blocker/1.13 This issue will prevent the release of the next version of Cilium. label May 22, 2023
@aanm
Copy link
Member

aanm commented May 22, 2023

@jrajahalme I've removed the release-blocker label because v1.13.3 is about to get out and this will make it to v1.13.4 as long it gets merged.

@jrajahalme
Copy link
Member Author

jenkins.cilium.io failing as a DNS target on each jenkins job, net-next still pending other tests.

@jrajahalme jrajahalme merged commit c355dde into cilium:v1.13 May 23, 2023
52 of 63 checks passed
@qmonnet qmonnet mentioned this pull request Jun 9, 2023
Closed
This was referenced Jun 9, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

Assignees
No one assigned
Labels
affects/v1.13 This issue affects v1.13 branch backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. kind/performance There is a performance impact of this. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jrajahalme @pchaigno @aanm