bpf,datapath: read jiffies from /proc/schedstat #25795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Cilium agent has been throwing the 'Auto-disabling "enable-bpf-clock-probe" feature since kernel doesn't expose /proc/timer_list' warning for a while now. Since /proc/timer_list is not available under the default k8s SecurityContext and Docker also masks the file by default, read it from /proc/schedstat instead. Reuse the existing parsing code from probes.KernelHZ to obtain the value. Signed-off-by: Timo Beckers <timo@isovalent.com>
ti-mo
added
kind/bug
ti-mo
added
the
release-blocker/1.14
|
/test |
rgo3
approved these changes
May 31, 2023
There was a problem hiding this comment.
Probably should have asked that back when we introduced the probe that relies on /proc/schedstat: Should we add CONFIG_SCHEDSTATS=y as a system requirement (for certain features) somewhere? I just realized that it's not set on my kernel and I'm missing /proc/schedstat.
borkmann
approved these changes
May 31, 2023
I think we should document it at https://docs.cilium.io/en/stable/operations/system_requirements/#linux-kernel. |
sayboras
added
backport-pending/1.13
maintainer-s-little-helper
bot
moved this from Needs backport from main
to Backport pending to v1.13
in 1.13.3
YutaroHayakawa
added
backport-done/1.13
maintainer-s-little-helper
bot
moved this from Backport pending to v1.13
to Backport done to v1.13
in 1.13.3
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Cilium agent has been throwing the 'Auto-disabling "enable-bpf-clock-probe" feature since kernel doesn't expose /proc/timer_list' warning for a while now.
Since /proc/timer_list is not available under the default k8s SecurityContext and Docker also masks the file by default, read it from /proc/schedstat instead.
Reuse the existing parsing code from probes.KernelHZ to obtain the value.
Fixes: #25463
Backporting to 1.13 only since 1.12 doesn't have the new /proc/schedstat reader infra yet.