Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wireguard: Always unset fwMark #25858

Merged
merged 1 commit into from
Jun 5, 2023
Merged

wireguard: Always unset fwMark #25858

merged 1 commit into from
Jun 5, 2023

Conversation

brb
Copy link
Member

@brb brb commented Jun 2, 2023 •
edited

Previously, when doing a downgrade from v1.14 (unreleased yet) to v1.13, the fwMark of cilium_wg0 set by v1.14 was not cleared by v1.13 which resulted in WireGuard peer's handshake failures.

No need to run full CI, ci-e2e is enough.

@brb
wireguard: Always unset fwMark
12f802e 
Previously, when doing a downgrade from v1.14 (unreleased yet) to v1.13,
the fwMark of cilium_wg0 set by v1.14 was not cleared by v1.13 which
resulted in WireGuard peer's handshake failures.

Signed-off-by: Martynas Pumputis <m@lambda.lt>
@brb brb added kind/bug This is a bug in the Cilium logic. kind/backports This PR provides functionality previously merged into master. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. labels Jun 2, 2023
@brb brb requested a review from a team as a code owner June 2, 2023 12:09
@brb
Copy link
Member Author

brb commented Jun 2, 2023

/ci-e2e-1.13

@brb brb requested review from a team and jschwinger233 and removed request for a team June 2, 2023 12:34
@joestringer joestringer added the upgrade-impact This PR has potential upgrade or downgrade impact. label Jun 2, 2023
@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 5, 2023
@dylandreimerink dylandreimerink merged commit 098d297 into v1.13 Jun 5, 2023
41 checks passed
@dylandreimerink dylandreimerink deleted the pr/brb/wg-remove-fwmark branch June 5, 2023 13:25
@qmonnet qmonnet mentioned this pull request Jun 9, 2023
Closed
This was referenced Jun 9, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@dylandreimerink dylandreimerink dylandreimerink approved these changes

@jschwinger233 jschwinger233 Awaiting requested review from jschwinger233 jschwinger233 was automatically assigned from cilium/sig-encryption

Assignees
No one assigned
Labels
area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport/1.13 This PR represents a backport for Cilium 1.13.x of a PR that was merged to main. kind/backports This PR provides functionality previously merged into master. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. upgrade-impact This PR has potential upgrade or downgrade impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@brb @gandro @dylandreimerink @joestringer