Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Detect default "desktop-linux" builder #25908

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

jrajahalme
Copy link
Member

New Docker desktop may have a default builder with name "desktop-linux" that is not buildx capable. Detect that name as well as the old "default" for the need to create a new buildx builder.

@jrajahalme jrajahalme added the release-note/misc This PR makes changes that have no direct user impact. label Jun 5, 2023
@jrajahalme jrajahalme requested a review from a team as a code owner June 5, 2023 15:26
@jrajahalme jrajahalme requested a review from borkmann June 5, 2023 15:26
@jrajahalme
Copy link
Member Author

jrajahalme commented Jun 5, 2023

Saw this locally like so after a recent Docker Desktop update to version 4.20.0:

% docker buildx ls
NAME/NODE       DRIVER/ENDPOINT             STATUS  BUILDKIT                              PLATFORMS
default         docker                                                                    
  default       default                     running v0.11.7-0.20230525183624-798ad6b0ce9f linux/arm64, linux/amd64, linux/amd64/v2, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/mips64le, linux/mips64, linux/arm/v7, linux/arm/v6
desktop-linux * docker                                                                    
  desktop-linux desktop-linux               running v0.11.7-0.20230525183624-798ad6b0ce9f linux/arm64, linux/amd64, linux/amd64/v2, linux/riscv64, linux/ppc64le, linux/s390x, linux/386, linux/mips64le, linux/mips64, linux/arm/v7, linux/arm/v6
% make            
Using Docker Buildx builder "desktop-linux" with build flags "--push --platform=linux/arm64,linux/amd64".
DOCKER_BUILDKIT=1 docker buildx build --push --platform=linux/arm64,linux/amd64 ...
[+] Building 0.0s (0/0)                                                                                                                                                                                                                               
ERROR: multiple platforms feature is currently not supported for docker driver. Please switch to a different driver (eg. "docker buildx create --use")
make: *** [...] Error 1

@jrajahalme
Copy link
Member Author

jrajahalme commented Jun 6, 2023

/test

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathServicesTest Checks E/W loadbalancing (ClusterIP, NodePort from inside cluster, etc) with L7 policy Tests NodePort with L7 Policy

Failure Output

FAIL: Request from testclient-tr4cw pod to service tftp://[fd04::11]:32095/hello failed

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.25-kernel-4.19/431/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

Then please upload the Jenkins artifacts to that issue.

@jrajahalme jrajahalme added needs-backport/1.11 needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.11.18 Jun 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.13.4 Jun 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from main in 1.12.11 Jun 6, 2023
@jrajahalme
Copy link
Member Author

/test-1.25-4.19

@jrajahalme
Copy link
Member Author

/test-1.26-net-next

New Docker desktop may have a default builder with name "desktop-linux"
that is not buildx capable. Detect that name as well as the old "default"
for the need to create a new buildx builder.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme
Copy link
Member Author

jrajahalme commented Jun 6, 2023

/test

Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed:

Click to show.

Test Name

K8sDatapathConfig Iptables Skip conntrack for pod traffic

Failure Output

FAIL: Found 2 k8s-app=cilium logs matching list of errors that must be investigated:

Jenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/515/

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.26-kernel-net-next so I can create one.

Then please upload the Jenkins artifacts to that issue.

@jrajahalme
Copy link
Member Author

/test-1.26-net-next

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jun 9, 2023
@dylandreimerink dylandreimerink merged commit 13f146e into cilium:main Jun 9, 2023
62 checks passed
@qmonnet qmonnet added this to Needs backport from main in 1.13.5 Jun 9, 2023
@qmonnet qmonnet removed this from Needs backport from main in 1.13.4 Jun 9, 2023
@pchaigno pchaigno mentioned this pull request Jun 9, 2023
5 tasks
@michi-covalent michi-covalent added this to Needs backport from main in 1.12.12 Jun 12, 2023
@michi-covalent michi-covalent removed this from Needs backport from main in 1.12.11 Jun 12, 2023
@michi-covalent michi-covalent mentioned this pull request Jun 13, 2023
7 tasks
@michi-covalent michi-covalent added this to Needs backport from main in 1.11.19 Jun 14, 2023
@michi-covalent michi-covalent removed this from Needs backport from main in 1.11.18 Jun 14, 2023
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
7 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Backport pending to v1.11 in 1.11.18 Jun 22, 2023
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
10 tasks
@nbusseneau nbusseneau mentioned this pull request Jun 22, 2023
19 tasks
@nbusseneau nbusseneau added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels Jun 22, 2023
@tklauser tklauser added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Jun 29, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.11 to Backport done to v1.11 in 1.11.18 Jun 29, 2023
@tklauser tklauser added backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.12 backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels Jun 29, 2023
@gentoo-root gentoo-root moved this from Needs backport from main to Backport done to v1.11 in 1.11.19 Jul 26, 2023
@gentoo-root gentoo-root moved this from Needs backport from main to Backport done to v1.12 in 1.12.12 Jul 26, 2023
@gentoo-root gentoo-root moved this from Needs backport from main to Backport done to v1.13 in 1.13.5 Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. backport-done/1.12 The backport for Cilium 1.12.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.11.18
Backport done to v1.11
1.11.19
Backport done to v1.11
1.12.12
Backport done to v1.12
1.13.5
Backport done to v1.13
Development

Successfully merging this pull request may close these issues.

None yet

5 participants